Python code modernization, 1/n (#1141)

* Remove unicode text prefixes.

* Replace str.format() uses with f-strings.

* Replace % with f-strings, and do some cleanup.

* Fix wrong variable.

* Avoid unnecessary string conversion.

plugins/module_utils/_api/credentials/errors.py

@@ -26,12 +26,8 @@ def process_store_error(cpe, program):
     message = cpe.output.decode('utf-8')
     if 'credentials not found in native keychain' in message:
         return CredentialsNotFound(
-            'No matching credentials in {0}'.format(
-                program
-            )
+            f'No matching credentials in {program}'
         )
     return StoreError(
-        'Credentials store {0} exited with "{1}".'.format(
-            program, cpe.output.decode('utf-8').strip()
-        )
+        f'Credentials store {program} exited with "{cpe.output.decode("utf-8").strip()}".'
     )

plugins/module_utils/_api/credentials/store.py

@@ -30,9 +30,7 @@ class Store(object):
         self.environment = environment
         if self.exe is None:
             raise errors.InitializationError(
-                '{0} not installed or not available in PATH'.format(
-                    self.program
-                )
+                f'{self.program} not installed or not available in PATH'
             )
 
     def get(self, server):
@@ -50,7 +48,7 @@ class Store(object):
         # raise CredentialsNotFound
         if result['Username'] == '' and result['Secret'] == '':
             raise errors.CredentialsNotFound(
-                'No matching credentials in {0}'.format(self.program)
+                f'No matching credentials in {self.program}'
             )
 
         return result
@@ -92,14 +90,10 @@ class Store(object):
         except OSError as e:
             if e.errno == errno.ENOENT:
                 raise errors.StoreError(
-                    '{0} not installed or not available in PATH'.format(
-                        self.program
-                    )
+                    f'{self.program} not installed or not available in PATH'
                 )
             else:
                 raise errors.StoreError(
-                    'Unexpected OS error "{0}", errno={1}'.format(
-                        e.strerror, e.errno
-                    )
+                    f'Unexpected OS error "{e.strerror}", errno={e.errno}'
                 )
         return output