From ec5f7682a19d0f789ccaa9008887ac940dfcd658 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Tue, 7 Oct 2025 22:05:05 +0200 Subject: [PATCH] Prevent loss of data. (#1152) --- changelogs/fragments/1152-fix.yml | 3 +++ plugins/module_utils/_socket_handler.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/1152-fix.yml diff --git a/changelogs/fragments/1152-fix.yml b/changelogs/fragments/1152-fix.yml new file mode 100644 index 00000000..e37289d6 --- /dev/null +++ b/changelogs/fragments/1152-fix.yml @@ -0,0 +1,3 @@ +bugfixes: + - "docker_api connection plugin - fix bug that could lead to loss of data when waiting for ``become`` plugin prompt (https://github.com/ansible-collections/community.docker/pull/1152)." + - "docker_container_exec - fix bug that could lead to loss of stdout/stderr data (https://github.com/ansible-collections/community.docker/pull/1152)." diff --git a/plugins/module_utils/_socket_handler.py b/plugins/module_utils/_socket_handler.py index f8bcc235..0476e918 100644 --- a/plugins/module_utils/_socket_handler.py +++ b/plugins/module_utils/_socket_handler.py @@ -63,7 +63,7 @@ class DockerSocketHandlerBase(object): self._block_done_callback = block_done_callback if self._block_done_callback is not None: while self._block_buffer: - elt = self._block_buffer.remove(0) + elt = self._block_buffer.pop(0) self._block_done_callback(*elt) def _add_block(self, stream_id, data):