From e42aadf3e9c3cef164c4be9da279a4b3f6701cf7 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Fri, 12 Mar 2021 22:01:11 +0100 Subject: [PATCH] docker_swarm_service: flag secrets option as not secret (#102) * Flag secrets option as not secret. * Add changelog fragment. --- changelogs/fragments/102-no_log-false.yml | 2 ++ plugins/modules/docker_swarm_service.py | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 changelogs/fragments/102-no_log-false.yml diff --git a/changelogs/fragments/102-no_log-false.yml b/changelogs/fragments/102-no_log-false.yml new file mode 100644 index 00000000..b279b3c8 --- /dev/null +++ b/changelogs/fragments/102-no_log-false.yml @@ -0,0 +1,2 @@ +bugfixes: +- "docker_swarm_service - mark ``secrets`` module option with ``no_log=False`` since it does not leak secrets (https://github.com/ansible-collections/community.general/pull/2001)." diff --git a/plugins/modules/docker_swarm_service.py b/plugins/modules/docker_swarm_service.py index 4d42a1e1..722fc080 100644 --- a/plugins/modules/docker_swarm_service.py +++ b/plugins/modules/docker_swarm_service.py @@ -2598,9 +2598,9 @@ def main(): gid=dict(type='str'), mode=dict(type='int'), )), - secrets=dict(type='list', elements='dict', options=dict( - secret_id=dict(type='str'), - secret_name=dict(type='str', required=True), + secrets=dict(type='list', elements='dict', no_log=False, options=dict( + secret_id=dict(type='str', no_log=False), + secret_name=dict(type='str', required=True, no_log=False), filename=dict(type='str'), uid=dict(type='str'), gid=dict(type='str'),