ansible-collections/community.docker
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.docker.git synced 2026-04-16 17:26:28 +00:00
Code Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
tpourcelot 2025-08-02 17:18:56 +02:00 committed by GitHub
parent f84cb60eb5
commit dec0ceeec8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/1108-replicated-job-support.yml
View File

@ -1,2 +1,2 @@
minor_changes: minor_changes:
- docker_swarm_service - Add support for ``replicated-job`` mode for Swarm services (https://github.com/ansible-collections/community.docker/issues/626) - docker_swarm_service - add support for ``replicated-job`` mode for Swarm services (https://github.com/ansible-collections/community.docker/issues/626, https://github.com/ansible-collections/community.docker/pull/1108).

4
plugins/modules/docker_swarm_service.py
View File

@ -237,7 +237,7 @@ options:
- Service replication mode. - Service replication mode.
- Service will be removed and recreated when changed. - Service will be removed and recreated when changed.
- Corresponds to the C(--mode) option of C(docker service create). - Corresponds to the C(--mode) option of C(docker service create).
- The value V(replicated-job) was added in community.docker 4.7.0 and requires API version >= 1.41. - The value V(replicated-job) was added in community.docker 4.7.0, and requires API version >= 1.41 and Docker SDK for Python >= 6.0.0.
type: str type: str
default: replicated default: replicated
choices: choices:
@ -2758,7 +2758,7 @@ def main():
) is not None, ) is not None,
usage_msg='set rollback_config.order' usage_msg='set rollback_config.order'
), ),
mode=dict( mode_replicated_job=dict(
docker_py_version='6.0.0', docker_py_version='6.0.0',
docker_api_version='1.41', docker_api_version='1.41',
detect_usage=lambda c: c.module.params.get('mode') == 'replicated-job', detect_usage=lambda c: c.module.params.get('mode') == 'replicated-job',

2
tests/integration/targets/docker_swarm_service/tasks/tests/options.yml
View File

@ -1348,7 +1348,7 @@
- assert: - assert:
that: that:
- mode_4 is changed - mode_4 is changed
- mode_5 is not changed - mode_5 is not changed and mode_5 is not failed
- mode_6 is changed - mode_6 is changed
when: docker_api_version is version('1.41', '>=') and docker_py_version is version('6.0.0', '>=') when: docker_api_version is version('1.41', '>=') and docker_py_version is version('6.0.0', '>=')