Normalize bools in tests. (#589)

tests/integration/targets/docker_swarm/tasks/cleanup.yml

@@ -7,7 +7,7 @@
   docker_swarm:
     state: absent
     force: true
-  ignore_errors: yes
+  ignore_errors: true
   register: leave_swarm
 
 - name: CLEANUP | Kill Docker and cleanup
@@ -15,7 +15,7 @@
   block:
     - name: CLEANUP | Kill docker daemon
       command: systemctl kill -s 9 docker
-      become: yes
+      become: true
 
     - name: CLEANUP | Clear out /var/lib/docker
       shell: rm -rf  /var/lib/docker/*
@@ -24,7 +24,7 @@
       service:
         name: docker
         state: started
-      become: yes
+      become: true
 
     - name: CLEANUP | Wait for docker daemon to be fully started
       command: docker ps

tests/integration/targets/docker_swarm/tasks/tests/basic.yml

@@ -12,7 +12,7 @@
 - name: Test parameters with state=join
   docker_swarm:
     state: join
-  ignore_errors: yes
+  ignore_errors: true
   register: output
 
 - name: assert failure when called with state=join and no remote_addrs,join_token
@@ -24,7 +24,7 @@
 - name: Test parameters with state=remove
   docker_swarm:
     state: remove
-  ignore_errors: yes
+  ignore_errors: true
   register: output
 
 - name: assert failure when called with state=remove and no node_id
@@ -41,47 +41,47 @@
   docker_swarm:
     state: present
     advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: Create a Swarm cluster
   docker_swarm:
     state: present
     advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
-  diff: yes
+  diff: true
   register: output_2
 
 - name: Create a Swarm cluster (idempotent)
   docker_swarm:
     state: present
     advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
-  diff: yes
+  diff: true
   register: output_3
 
 - name: Create a Swarm cluster (idempotent, check mode)
   docker_swarm:
     state: present
     advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: Create a Swarm cluster (force re-create)
   docker_swarm:
     state: present
     advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
-    force: yes
-  diff: yes
+    force: true
+  diff: true
   register: output_5
 
 - name: Create a Swarm cluster (force re-create, check mode)
   docker_swarm:
     state: present
     advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
-    force: yes
-  check_mode: yes
-  diff: yes
+    force: true
+  check_mode: true
+  diff: true
   register: output_6
 
 - name: assert changed when create a new swarm cluster
@@ -117,30 +117,30 @@
   docker_swarm:
     state: absent
     force: true
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: Remove a Swarm cluster
   docker_swarm:
     state: absent
     force: true
-  diff: yes
+  diff: true
   register: output_2
 
 - name: Remove a Swarm cluster (idempotent)
   docker_swarm:
     state: absent
     force: true
-  diff: yes
+  diff: true
   register: output_3
 
 - name: Remove a Swarm cluster (idempotent, check mode)
   docker_swarm:
     state: absent
     force: true
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: assert changed when remove a swarm cluster

tests/integration/targets/docker_swarm/tasks/tests/options.yml

@@ -11,7 +11,7 @@
     state: present
     advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
     name: default
-  diff: yes
+  diff: true
 
 ####################################################################
 ## autolock_managers ###############################################
@@ -20,63 +20,63 @@
 - name: autolock_managers (check mode)
   docker_swarm:
     state: present
-    autolock_managers: yes
-  check_mode: yes
-  diff: yes
+    autolock_managers: true
+  check_mode: true
+  diff: true
   register: output_1
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: autolock_managers
   docker_swarm:
     state: present
-    autolock_managers: yes
-  diff: yes
+    autolock_managers: true
+  diff: true
   register: output_2
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: autolock_managers (idempotent)
   docker_swarm:
     state: present
-    autolock_managers: yes
-  diff: yes
+    autolock_managers: true
+  diff: true
   register: output_3
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: autolock_managers (idempotent, check mode)
   docker_swarm:
     state: present
-    autolock_managers: yes
-  check_mode: yes
-  diff: yes
+    autolock_managers: true
+  check_mode: true
+  diff: true
   register: output_4
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: autolock_managers (change, check mode)
   docker_swarm:
     state: present
-    autolock_managers: no
-  check_mode: yes
-  diff: yes
+    autolock_managers: false
+  check_mode: true
+  diff: true
   register: output_5
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: autolock_managers (change)
   docker_swarm:
     state: present
-    autolock_managers: no
-  diff: yes
+    autolock_managers: false
+  diff: true
   register: output_6
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: autolock_managers (force new swarm)
   docker_swarm:
     state: present
-    force: yes
+    force: true
     advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
-    autolock_managers: yes
-  diff: yes
+    autolock_managers: true
+  diff: true
   register: output_7
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: assert autolock_managers changes
   assert:
@@ -131,52 +131,52 @@
   docker_swarm:
     state: present
     ca_force_rotate: 1
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: ca_force_rotate
   docker_swarm:
     state: present
     ca_force_rotate: 1
-  diff: yes
+  diff: true
   register: output_2
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: ca_force_rotate (idempotent)
   docker_swarm:
     state: present
     ca_force_rotate: 1
-  diff: yes
+  diff: true
   register: output_3
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: ca_force_rotate (idempotent, check mode)
   docker_swarm:
     state: present
     ca_force_rotate: 1
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: ca_force_rotate (change, check mode)
   docker_swarm:
     state: present
     ca_force_rotate: 0
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: ca_force_rotate (change)
   docker_swarm:
     state: present
     ca_force_rotate: 0
-  diff: yes
+  diff: true
   register: output_6
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: assert ca_force_rotate changes
   assert:
@@ -221,45 +221,45 @@
   docker_swarm:
     state: present
     dispatcher_heartbeat_period: 10
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: dispatcher_heartbeat_period
   docker_swarm:
     state: present
     dispatcher_heartbeat_period: 10
-  diff: yes
+  diff: true
   register: output_2
 
 - name: dispatcher_heartbeat_period (idempotent)
   docker_swarm:
     state: present
     dispatcher_heartbeat_period: 10
-  diff: yes
+  diff: true
   register: output_3
 
 - name: dispatcher_heartbeat_period (idempotent, check mode)
   docker_swarm:
     state: present
     dispatcher_heartbeat_period: 10
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: dispatcher_heartbeat_period (change, check mode)
   docker_swarm:
     state: present
     dispatcher_heartbeat_period: 23
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
 
 - name: dispatcher_heartbeat_period (change)
   docker_swarm:
     state: present
     dispatcher_heartbeat_period: 23
-  diff: yes
+  diff: true
   register: output_6
 
 - name: assert dispatcher_heartbeat_period changes
@@ -298,45 +298,45 @@
   docker_swarm:
     state: present
     election_tick: 20
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: election_tick
   docker_swarm:
     state: present
     election_tick: 20
-  diff: yes
+  diff: true
   register: output_2
 
 - name: election_tick (idempotent)
   docker_swarm:
     state: present
     election_tick: 20
-  diff: yes
+  diff: true
   register: output_3
 
 - name: election_tick (idempotent, check mode)
   docker_swarm:
     state: present
     election_tick: 20
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: election_tick (change, check mode)
   docker_swarm:
     state: present
     election_tick: 5
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
 
 - name: election_tick (change)
   docker_swarm:
     state: present
     election_tick: 5
-  diff: yes
+  diff: true
   register: output_6
 
 - name: assert election_tick changes
@@ -375,45 +375,45 @@
   docker_swarm:
     state: present
     heartbeat_tick: 2
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: heartbeat_tick
   docker_swarm:
     state: present
     heartbeat_tick: 2
-  diff: yes
+  diff: true
   register: output_2
 
 - name: heartbeat_tick (idempotent)
   docker_swarm:
     state: present
     heartbeat_tick: 2
-  diff: yes
+  diff: true
   register: output_3
 
 - name: heartbeat_tick (idempotent, check mode)
   docker_swarm:
     state: present
     heartbeat_tick: 2
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: heartbeat_tick (change, check mode)
   docker_swarm:
     state: present
     heartbeat_tick: 3
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
 
 - name: heartbeat_tick (change)
   docker_swarm:
     state: present
     heartbeat_tick: 3
-  diff: yes
+  diff: true
   register: output_6
 
 - name: assert heartbeat_tick changes
@@ -451,45 +451,45 @@
   docker_swarm:
     state: present
     keep_old_snapshots: 1
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: keep_old_snapshots
   docker_swarm:
     state: present
     keep_old_snapshots: 1
-  diff: yes
+  diff: true
   register: output_2
 
 - name: keep_old_snapshots (idempotent)
   docker_swarm:
     state: present
     keep_old_snapshots: 1
-  diff: yes
+  diff: true
   register: output_3
 
 - name: keep_old_snapshots (idempotent, check mode)
   docker_swarm:
     state: present
     keep_old_snapshots: 1
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: keep_old_snapshots (change, check mode)
   docker_swarm:
     state: present
     keep_old_snapshots: 2
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
 
 - name: keep_old_snapshots (change)
   docker_swarm:
     state: present
     keep_old_snapshots: 2
-  diff: yes
+  diff: true
   register: output_6
 
 - name: assert keep_old_snapshots changes
@@ -529,10 +529,10 @@
     labels:
       a: v1
       b: v2
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels
   docker_swarm:
@@ -540,9 +540,9 @@
     labels:
       a: v1
       b: v2
-  diff: yes
+  diff: true
   register: output_2
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (idempotent)
   docker_swarm:
@@ -550,9 +550,9 @@
     labels:
       a: v1
       b: v2
-  diff: yes
+  diff: true
   register: output_3
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (idempotent, check mode)
   docker_swarm:
@@ -560,10 +560,10 @@
     labels:
       a: v1
       b: v2
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (change, check mode)
   docker_swarm:
@@ -571,10 +571,10 @@
     labels:
       a: v1
       c: v3
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (change)
   docker_swarm:
@@ -582,24 +582,24 @@
     labels:
       a: v1
       c: v3
-  diff: yes
+  diff: true
   register: output_6
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (not specifying, check mode)
   docker_swarm:
     state: present
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_7
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (not specifying)
   docker_swarm:
     state: present
-  diff: yes
+  diff: true
   register: output_8
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (idempotency, check that labels are still there)
   docker_swarm:
@@ -607,43 +607,43 @@
     labels:
       a: v1
       c: v3
-  diff: yes
+  diff: true
   register: output_9
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (empty, check mode)
   docker_swarm:
     state: present
     labels: {}
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_10
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (empty)
   docker_swarm:
     state: present
     labels: {}
-  diff: yes
+  diff: true
   register: output_11
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (empty, idempotent, check mode)
   docker_swarm:
     state: present
     labels: {}
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_12
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: labels (empty, idempotent)
   docker_swarm:
     state: present
     labels: {}
-  diff: yes
+  diff: true
   register: output_13
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: assert labels changes
   assert:
@@ -715,45 +715,45 @@
   docker_swarm:
     state: present
     log_entries_for_slow_followers: 42
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: log_entries_for_slow_followers
   docker_swarm:
     state: present
     log_entries_for_slow_followers: 42
-  diff: yes
+  diff: true
   register: output_2
 
 - name: log_entries_for_slow_followers (idempotent)
   docker_swarm:
     state: present
     log_entries_for_slow_followers: 42
-  diff: yes
+  diff: true
   register: output_3
 
 - name: log_entries_for_slow_followers (idempotent, check mode)
   docker_swarm:
     state: present
     log_entries_for_slow_followers: 42
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: log_entries_for_slow_followers (change, check mode)
   docker_swarm:
     state: present
     log_entries_for_slow_followers: 23
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
 
 - name: log_entries_for_slow_followers (change)
   docker_swarm:
     state: present
     log_entries_for_slow_followers: 23
-  diff: yes
+  diff: true
   register: output_6
 
 - name: assert log_entries_for_slow_followers changes
@@ -791,15 +791,15 @@
   docker_swarm:
     state: present
     name: default
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: name (idempotent)
   docker_swarm:
     state: present
     name: default
-  diff: yes
+  diff: true
   register: output_2
 
 # The name 'default' is hardcoded in docker swarm. Trying to change
@@ -809,9 +809,9 @@
   docker_swarm:
     state: present
     name: foobar
-  diff: yes
+  diff: true
   register: output_3
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: assert name changes
   assert:
@@ -833,45 +833,45 @@
   docker_swarm:
     state: present
     node_cert_expiry: 7896000000000000
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: node_cert_expiry
   docker_swarm:
     state: present
     node_cert_expiry: 7896000000000000
-  diff: yes
+  diff: true
   register: output_2
 
 - name: node_cert_expiry (idempotent)
   docker_swarm:
     state: present
     node_cert_expiry: 7896000000000000
-  diff: yes
+  diff: true
   register: output_3
 
 - name: node_cert_expiry (idempotent, check mode)
   docker_swarm:
     state: present
     node_cert_expiry: 7896000000000000
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: node_cert_expiry (change, check mode)
   docker_swarm:
     state: present
     node_cert_expiry: 8766000000000000
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
 
 - name: node_cert_expiry (change)
   docker_swarm:
     state: present
     node_cert_expiry: 8766000000000000
-  diff: yes
+  diff: true
   register: output_6
 
 - name: assert node_cert_expiry changes
@@ -908,31 +908,31 @@
 - name: rotate_manager_token (true, check mode)
   docker_swarm:
     state: present
-    rotate_manager_token: yes
-  check_mode: yes
-  diff: yes
+    rotate_manager_token: true
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: rotate_manager_token (true)
   docker_swarm:
     state: present
-    rotate_manager_token: yes
-  diff: yes
+    rotate_manager_token: true
+  diff: true
   register: output_2
 
 - name: rotate_manager_token (false, idempotent)
   docker_swarm:
     state: present
-    rotate_manager_token: no
-  diff: yes
+    rotate_manager_token: false
+  diff: true
   register: output_3
 
 - name: rotate_manager_token (false, check mode)
   docker_swarm:
     state: present
-    rotate_manager_token: no
-  check_mode: yes
-  diff: yes
+    rotate_manager_token: false
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: assert rotate_manager_token changes
@@ -961,31 +961,31 @@
 - name: rotate_worker_token (true, check mode)
   docker_swarm:
     state: present
-    rotate_worker_token: yes
-  check_mode: yes
-  diff: yes
+    rotate_worker_token: true
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: rotate_worker_token (true)
   docker_swarm:
     state: present
-    rotate_worker_token: yes
-  diff: yes
+    rotate_worker_token: true
+  diff: true
   register: output_2
 
 - name: rotate_worker_token (false, idempotent)
   docker_swarm:
     state: present
-    rotate_worker_token: no
-  diff: yes
+    rotate_worker_token: false
+  diff: true
   register: output_3
 
 - name: rotate_worker_token (false, check mode)
   docker_swarm:
     state: present
-    rotate_worker_token: no
-  check_mode: yes
-  diff: yes
+    rotate_worker_token: false
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: assert rotate_worker_token changes
@@ -1015,45 +1015,45 @@
   docker_swarm:
     state: present
     snapshot_interval: 12345
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: snapshot_interval
   docker_swarm:
     state: present
     snapshot_interval: 12345
-  diff: yes
+  diff: true
   register: output_2
 
 - name: snapshot_interval (idempotent)
   docker_swarm:
     state: present
     snapshot_interval: 12345
-  diff: yes
+  diff: true
   register: output_3
 
 - name: snapshot_interval (idempotent, check mode)
   docker_swarm:
     state: present
     snapshot_interval: 12345
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: snapshot_interval (change, check mode)
   docker_swarm:
     state: present
     snapshot_interval: 54321
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
 
 - name: snapshot_interval (change)
   docker_swarm:
     state: present
     snapshot_interval: 54321
-  diff: yes
+  diff: true
   register: output_6
 
 - name: assert snapshot_interval changes
@@ -1091,45 +1091,45 @@
   docker_swarm:
     state: present
     task_history_retention_limit: 23
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_1
 
 - name: task_history_retention_limit
   docker_swarm:
     state: present
     task_history_retention_limit: 23
-  diff: yes
+  diff: true
   register: output_2
 
 - name: task_history_retention_limit (idempotent)
   docker_swarm:
     state: present
     task_history_retention_limit: 23
-  diff: yes
+  diff: true
   register: output_3
 
 - name: task_history_retention_limit (idempotent, check mode)
   docker_swarm:
     state: present
     task_history_retention_limit: 23
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_4
 
 - name: task_history_retention_limit (change, check mode)
   docker_swarm:
     state: present
     task_history_retention_limit: 7
-  check_mode: yes
-  diff: yes
+  check_mode: true
+  diff: true
   register: output_5
 
 - name: task_history_retention_limit (change)
   docker_swarm:
     state: present
     task_history_retention_limit: 7
-  diff: yes
+  diff: true
   register: output_6
 
 - name: assert task_history_retention_limit changes

tests/integration/targets/docker_swarm/tasks/tests/remote-addr-pool.yml

@@ -15,18 +15,18 @@
     state: present
     default_addr_pool:
       - "2.0.0.0/16"
-  diff: yes
+  diff: true
   register: output_1
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: default_addr_pool (idempotent)
   docker_swarm:
     state: present
     default_addr_pool:
       - "2.0.0.0/16"
-  diff: yes
+  diff: true
   register: output_2
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: assert default_addr_pool
   assert:
@@ -52,27 +52,27 @@
 - name: Leave swarm
   docker_swarm:
     state: absent
-    force: yes
+    force: true
     default_addr_pool:
       - "2.0.0.0/16"
-  diff: yes
+  diff: true
 
 - name: subnet_size
   docker_swarm:
     state: present
-    force: yes
+    force: true
     subnet_size: 26
-  diff: yes
+  diff: true
   register: output_1
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: subnet_size (idempotent)
   docker_swarm:
     state: present
     subnet_size: 26
-  diff: yes
+  diff: true
   register: output_2
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: assert subnet_size
   assert: