Avoid losing data from events if multiple arrive at the same time. (#1158) (#1159)

(cherry picked from commit f7e976f3da)
This commit is contained in:
Felix Fontein
2025-10-10 20:28:27 +02:00
committed by GitHub
parent 3b0ab3bd8b
commit db20b1876d
3 changed files with 17 additions and 4 deletions
+7 -2
View File
@@ -378,16 +378,21 @@ class Connection(ConnectionBase):
stdout, stderr = p.communicate()
raise AnsibleError('timeout waiting for privilege escalation password prompt:\n' + to_native(become_output))
chunks = b""
for key, event in events:
if key.fileobj == p.stdout:
chunk = p.stdout.read()
if chunk:
chunks += chunk
elif key.fileobj == p.stderr:
chunk = p.stderr.read()
if chunk:
chunks += chunk
if not chunk:
if not chunks:
stdout, stderr = p.communicate()
raise AnsibleError('privilege output closed while waiting for password prompt:\n' + to_native(become_output))
become_output += chunk
become_output += chunks
finally:
selector.close()
+7 -2
View File
@@ -166,16 +166,21 @@ class Connection(ConnectionBase):
stdout, stderr = p.communicate()
raise AnsibleError('timeout waiting for privilege escalation password prompt:\n' + to_native(become_output))
chunks = b""
for key, event in events:
if key.fileobj == p.stdout:
chunk = p.stdout.read()
if chunk:
chunks += chunk
elif key.fileobj == p.stderr:
chunk = p.stderr.read()
if chunk:
chunks += chunk
if not chunk:
if not chunks:
stdout, stderr = p.communicate()
raise AnsibleError('privilege output closed while waiting for password prompt:\n' + to_native(become_output))
become_output += chunk
become_output += chunks
finally:
selector.close()