Python code modernization, 4/n (#1162)

* Address attribute-defined-outside-init.

* Address broad-exception-raised.

* Address broad-exception-caught.

* Address consider-iterating-dictionary.

* Address consider-using-dict-comprehension.

* Address consider-using-f-string.

* Address consider-using-in.

* Address consider-using-max-builtin.

* Address some consider-using-with.

* Address invalid-name.

* Address keyword-arg-before-vararg.

* Address line-too-long.

* Address no-else-continue.

* Address no-else-raise.

* Address no-else-return.

* Remove broken dead code.

* Make consider-using-f-string changes compatible with older Python versions.

* Python 3.11 and earlier apparently do not like multi-line f-strings.

tests/unit/plugins/test_support/docker_image_archive_stubbing.py

@@ -50,8 +50,7 @@ def write_irrelevant_tar(file_name):
     :type file_name: str
     """
 
-    tf = tarfile.open(file_name, "w")
-    try:
+    with tarfile.open(file_name, "w") as tf:
         with TemporaryFile() as f:
             f.write("Hello, world.".encode("utf-8"))
 
@@ -60,6 +59,3 @@ def write_irrelevant_tar(file_name):
 
             f.seek(0)
             tf.addfile(ti, f)
-
-    finally:
-        tf.close()