Python code modernization, 4/n (#1162)

* Address attribute-defined-outside-init.

* Address broad-exception-raised.

* Address broad-exception-caught.

* Address consider-iterating-dictionary.

* Address consider-using-dict-comprehension.

* Address consider-using-f-string.

* Address consider-using-in.

* Address consider-using-max-builtin.

* Address some consider-using-with.

* Address invalid-name.

* Address keyword-arg-before-vararg.

* Address line-too-long.

* Address no-else-continue.

* Address no-else-raise.

* Address no-else-return.

* Remove broken dead code.

* Make consider-using-f-string changes compatible with older Python versions.

* Python 3.11 and earlier apparently do not like multi-line f-strings.

plugins/module_utils/_socket_handler.py

@@ -78,15 +78,14 @@ class DockerSocketHandlerBase:
         if hasattr(self._sock, "recv"):
             try:
                 data = self._sock.recv(262144)
-            except Exception as e:
+            except Exception as e:  # pylint: disable=broad-exception-caught
                 # After calling self._sock.shutdown(), OpenSSL's/urllib3's
                 # WrappedSocket seems to eventually raise ZeroReturnError in
                 # case of EOF
                 if "OpenSSL.SSL.ZeroReturnError" in str(type(e)):
                     self._eof = True
                     return
-                else:
-                    raise
+                raise
         elif isinstance(self._sock, getattr(pysocket, "SocketIO")):
             data = self._sock.read()
         else: