Python code modernization, 4/n (#1162)

* Address attribute-defined-outside-init.

* Address broad-exception-raised.

* Address broad-exception-caught.

* Address consider-iterating-dictionary.

* Address consider-using-dict-comprehension.

* Address consider-using-f-string.

* Address consider-using-in.

* Address consider-using-max-builtin.

* Address some consider-using-with.

* Address invalid-name.

* Address keyword-arg-before-vararg.

* Address line-too-long.

* Address no-else-continue.

* Address no-else-raise.

* Address no-else-return.

* Remove broken dead code.

* Make consider-using-f-string changes compatible with older Python versions.

* Python 3.11 and earlier apparently do not like multi-line f-strings.

plugins/module_utils/_api/transport/npipesocket.py

@@ -28,9 +28,9 @@ except ImportError:
     PYWIN32_IMPORT_ERROR = traceback.format_exc()
 
 
-cERROR_PIPE_BUSY = 0xE7
-cSECURITY_SQOS_PRESENT = 0x100000
-cSECURITY_ANONYMOUS = 0
+ERROR_PIPE_BUSY = 0xE7
+SECURITY_SQOS_PRESENT = 0x100000
+SECURITY_ANONYMOUS = 0
 
 MAXIMUM_RETRY_COUNT = 10
 
@@ -55,7 +55,9 @@ class NpipeSocket:
     def __init__(self, handle=None):
         self._timeout = win32pipe.NMPWAIT_USE_DEFAULT_WAIT
         self._handle = handle
+        self._address = None
         self._closed = False
+        self.flags = None
 
     def accept(self):
         raise NotImplementedError()
@@ -77,8 +79,8 @@ class NpipeSocket:
                 None,
                 win32file.OPEN_EXISTING,
                 (
-                    cSECURITY_ANONYMOUS
-                    | cSECURITY_SQOS_PRESENT
+                    SECURITY_ANONYMOUS
+                    | SECURITY_SQOS_PRESENT
                     | win32file.FILE_FLAG_OVERLAPPED
                 ),
                 0,
@@ -86,7 +88,7 @@ class NpipeSocket:
         except win32pipe.error as e:
             # See Remarks:
             # https://msdn.microsoft.com/en-us/library/aa365800.aspx
-            if e.winerror == cERROR_PIPE_BUSY:
+            if e.winerror == ERROR_PIPE_BUSY:
                 # Another program or thread has grabbed our pipe instance
                 # before we got to it. Wait for availability and attempt to
                 # connect again.

plugins/module_utils/_api/transport/sshconn.py

@@ -72,7 +72,7 @@ class SSHSocket(socket.socket):
         env.pop("LD_LIBRARY_PATH", None)
         env.pop("SSL_CERT_FILE", None)
 
-        self.proc = subprocess.Popen(
+        self.proc = subprocess.Popen(  # pylint: disable=consider-using-with
             args,
             env=env,
             stdout=subprocess.PIPE,
@@ -82,7 +82,7 @@ class SSHSocket(socket.socket):
 
     def _write(self, data):
         if not self.proc or self.proc.stdin.closed:
-            raise Exception(
+            raise RuntimeError(
                 "SSH subprocess not initiated. connect() must be called first."
             )
         written = self.proc.stdin.write(data)
@@ -97,7 +97,7 @@ class SSHSocket(socket.socket):
 
     def recv(self, n):
         if not self.proc:
-            raise Exception(
+            raise RuntimeError(
                 "SSH subprocess not initiated. connect() must be called first."
             )
         return self.proc.stdout.read(n)