Python code modernization, 4/n (#1162)

* Address attribute-defined-outside-init.

* Address broad-exception-raised.

* Address broad-exception-caught.

* Address consider-iterating-dictionary.

* Address consider-using-dict-comprehension.

* Address consider-using-f-string.

* Address consider-using-in.

* Address consider-using-max-builtin.

* Address some consider-using-with.

* Address invalid-name.

* Address keyword-arg-before-vararg.

* Address line-too-long.

* Address no-else-continue.

* Address no-else-raise.

* Address no-else-return.

* Remove broken dead code.

* Make consider-using-f-string changes compatible with older Python versions.

* Python 3.11 and earlier apparently do not like multi-line f-strings.

plugins/inventory/docker_machine.py

@@ -125,16 +125,16 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable):
 
     NAME = "community.docker.docker_machine"
 
-    DOCKER_MACHINE_PATH = None
+    docker_machine_path = None
 
     def _run_command(self, args):
-        if not self.DOCKER_MACHINE_PATH:
+        if not self.docker_machine_path:
             try:
-                self.DOCKER_MACHINE_PATH = get_bin_path("docker-machine")
+                self.docker_machine_path = get_bin_path("docker-machine")
             except ValueError as e:
                 raise AnsibleError(to_native(e))
 
-        command = [self.DOCKER_MACHINE_PATH]
+        command = [self.docker_machine_path]
         command.extend(args)
         display.debug(f"Executing command {command}")
         try:
@@ -217,11 +217,11 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable):
                 if daemon_env == "require":
                     display.warning(f"{warning_prefix}: host will be skipped")
                 return True
-            else:  # 'optional', 'optional-silently'
-                if daemon_env == "optional":
-                    display.warning(
-                        f"{warning_prefix}: host will lack dm_DOCKER_xxx variables"
-                    )
+            if daemon_env == "optional":
+                display.warning(
+                    f"{warning_prefix}: host will lack dm_DOCKER_xxx variables"
+                )
+            # daemon_env is 'optional-silently'
         return False
 
     def _populate(self):

plugins/inventory/docker_swarm.py

@@ -199,7 +199,7 @@ class InventoryModule(BaseInventoryPlugin, Constructable):
         )
         update_tls_hostname(raw_params)
         connect_params = get_connect_params(raw_params, fail_function=self._fail)
-        self.client = docker.DockerClient(**connect_params)
+        client = docker.DockerClient(**connect_params)
         self.inventory.add_group("all")
         self.inventory.add_group("manager")
         self.inventory.add_group("worker")
@@ -217,9 +217,9 @@ class InventoryModule(BaseInventoryPlugin, Constructable):
                 host_uri_port = "2375"
 
         try:
-            self.nodes = self.client.nodes.list()
-            for node in self.nodes:
-                node_attrs = self.client.nodes.get(node.id).attrs
+            nodes = client.nodes.list()
+            for node in nodes:
+                node_attrs = client.nodes.get(node.id).attrs
                 unsafe_node_attrs = make_unsafe(node_attrs)
                 if not filter_host(
                     self, unsafe_node_attrs["ID"], unsafe_node_attrs, filters