Use FQCNs. (#1180)

tests/integration/targets/docker_image_push/tasks/main.yml

@@ -9,5 +9,5 @@
 ####################################################################
 
 - when: ansible_facts.distribution ~ ansible_facts.distribution_major_version not in ['CentOS6', 'RedHat6']
-  include_tasks:
+  ansible.builtin.include_tasks:
     file: test.yml

tests/integration/targets/docker_image_push/tasks/run-test.yml

@@ -4,4 +4,4 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 - name: "Loading tasks from {{ test_name }}"
-  include_tasks: "{{ test_name }}"
+  ansible.builtin.include_tasks: "{{ test_name }}"

tests/integration/targets/docker_image_push/tasks/test.yml

@@ -4,18 +4,18 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 - name: Create random name prefix
-  set_fact:
+  ansible.builtin.set_fact:
     name_prefix: "{{ 'ansible-docker-test-%0x' % ((2**32) | random) }}"
 - name: Create image and container list
-  set_fact:
+  ansible.builtin.set_fact:
     inames: []
     cnames: []
 
-- debug:
+- ansible.builtin.debug:
     msg: "Using name prefix {{ name_prefix }}"
 
 - block:
-    - include_tasks: run-test.yml
+    - ansible.builtin.include_tasks: run-test.yml
       with_fileglob:
         - "tests/*.yml"
       loop_control:
@@ -23,11 +23,11 @@
 
   always:
     - name: "Make sure all images are removed"
-      docker_image_remove:
+      community.docker.docker_image_remove:
         name: "{{ item }}"
       with_items: "{{ inames }}"
     - name: "Make sure all containers are removed"
-      docker_container:
+      community.docker.docker_container:
         name: "{{ item }}"
         state: absent
         force_kill: true
@@ -35,5 +35,5 @@
 
   when: docker_api_version is version('1.25', '>=')
 
-- fail: msg="Too old docker / docker-py version to run docker_image tests!"
+- ansible.builtin.fail: msg="Too old docker / docker-py version to run docker_image tests!"
   when: not(docker_api_version is version('1.25', '>=')) and (ansible_distribution != 'CentOS' or ansible_distribution_major_version|int > 6)

tests/integration/targets/docker_image_push/tasks/tests/basic.yml

@@ -7,41 +7,41 @@
     image_name: registry.example.com:5000/foo/bar:baz
   block:
     - name: Make sure image is not present
-      docker_image_remove:
+      community.docker.docker_image_remove:
         name: "{{ image_name }}"
 
     - name: Push non-existing image (must fail)
-      docker_image_push:
+      community.docker.docker_image_push:
         name: "{{ image_name }}"
       register: fail_1
       ignore_errors: true
 
     - name: Push image ID (must fail)
-      docker_image_push:
+      community.docker.docker_image_push:
         name: "sha256:{{ docker_test_image_digest_v1_image_id }}"
       register: fail_2
       ignore_errors: true
 
     - name: Push image with digest (must fail)
-      docker_image_push:
+      community.docker.docker_image_push:
         name: "{{ docker_test_image_digest_base }}@sha256:{{ docker_test_image_digest_v1 }}"
       register: fail_3
       ignore_errors: true
 
     - name: Push invalid tag (must fail)
-      docker_image_push:
+      community.docker.docker_image_push:
         name: "{{ docker_test_image_hello_world }}"
         tag: foo/bar
       register: fail_4
       ignore_errors: true
 
     - name: Push invalid tag 2 (must fail)
-      docker_image_push:
+      community.docker.docker_image_push:
         name: "{{ docker_test_image_digest_base }}:foo bar"
       register: fail_5
       ignore_errors: true
 
-    - assert:
+    - ansible.builtin.assert:
         that:
           - fail_1 is failed
           - >-

tests/integration/targets/docker_image_push/tasks/tests/registry.yml

@@ -7,7 +7,7 @@
   when: registry_address is defined
   block:
     - name: Pull images
-      docker_image_pull:
+      community.docker.docker_image_pull:
         name: "{{ item }}"
       loop:
         - "{{ docker_test_image_hello_world }}"
@@ -15,44 +15,44 @@
       register: pulled_images
 
     - name: Determining pushed image names
-      set_fact:
+      ansible.builtin.set_fact:
         image_name_base: "{{ registry_address }}/test/{{ name_prefix }}"
         image_name_base2: "{{ registry_frontend2_address }}/test/{{ name_prefix }}"
         image_tag: latest
 
     - name: Registering image name
-      set_fact:
+      ansible.builtin.set_fact:
         inames: "{{ inames + [image_name_base ~ ':' ~ image_tag, image_name_base2 ~ ':' ~ image_tag] }}"
 
     - name: Tag first image
-      docker_image_tag:
+      community.docker.docker_image_tag:
         name: "{{ docker_test_image_hello_world }}"
         repository:
           - "{{ image_name_base }}:{{ image_tag }}"
           - "{{ image_name_base2 }}:{{ image_tag }}"
 
     - name: Push first image
-      docker_image_push:
+      community.docker.docker_image_push:
         name: "{{ image_name_base }}:{{ image_tag }}"
       register: push_1
 
     - name: Push first image (idempotent)
-      docker_image_push:
+      community.docker.docker_image_push:
         name: "{{ image_name_base }}:{{ image_tag }}"
       register: push_2
 
     - name: Tag second image
-      docker_image_tag:
+      community.docker.docker_image_tag:
         name: "{{ docker_test_image_alpine }}"
         repository:
           - "{{ image_name_base }}:{{ image_tag }}"
 
     - name: Push second image with same name
-      docker_image_push:
+      community.docker.docker_image_push:
         name: "{{ image_name_base }}:{{ image_tag }}"
       register: push_3
 
-    - assert:
+    - ansible.builtin.assert:
         that:
           - push_1 is changed
           - push_1.image.Id == pulled_images.results[0].image.Id
@@ -64,19 +64,19 @@
     - when: registry_frontend2_address != 'n/a'
       block:
         - name: Make sure we are logged out from registry
-          docker_login:
+          community.docker.docker_login:
             registry_url: "{{ registry_frontend2_address }}"
             username: testuser
             password: hunter2
             state: absent
 
         - name: Push image (unauthenticated)
-          docker_image_push:
+          community.docker.docker_image_push:
             name: "{{ image_name_base2 }}:{{ image_tag }}"
           register: push_4
           ignore_errors: true
 
-        - assert:
+        - ansible.builtin.assert:
             that:
               - push_4 is failed
               - >-