Use FQCNs. (#1180)

This commit is contained in:
Felix Fontein
2025-10-25 10:12:21 +02:00
committed by GitHub
parent be000755fc
commit b24bce77b6
196 changed files with 3289 additions and 3289 deletions
@@ -9,5 +9,5 @@
####################################################################
- when: ansible_facts.distribution ~ ansible_facts.distribution_major_version not in ['CentOS6', 'RedHat6']
include_tasks:
ansible.builtin.include_tasks:
file: test.yml
@@ -4,4 +4,4 @@
# SPDX-License-Identifier: GPL-3.0-or-later
- name: "Loading tasks from {{ test_name }}"
include_tasks: "{{ test_name }}"
ansible.builtin.include_tasks: "{{ test_name }}"
@@ -4,18 +4,18 @@
# SPDX-License-Identifier: GPL-3.0-or-later
- name: Create random name prefix
set_fact:
ansible.builtin.set_fact:
name_prefix: "{{ 'ansible-docker-test-%0x' % ((2**32) | random) }}"
- name: Create image and container list
set_fact:
ansible.builtin.set_fact:
inames: []
cnames: []
- debug:
- ansible.builtin.debug:
msg: "Using name prefix {{ name_prefix }}"
- block:
- include_tasks: run-test.yml
- ansible.builtin.include_tasks: run-test.yml
with_fileglob:
- "tests/*.yml"
loop_control:
@@ -23,11 +23,11 @@
always:
- name: "Make sure all images are removed"
docker_image_remove:
community.docker.docker_image_remove:
name: "{{ item }}"
with_items: "{{ inames }}"
- name: "Make sure all containers are removed"
docker_container:
community.docker.docker_container:
name: "{{ item }}"
state: absent
force_kill: true
@@ -35,5 +35,5 @@
when: docker_api_version is version('1.25', '>=')
- fail: msg="Too old docker / docker-py version to run docker_image tests!"
- ansible.builtin.fail: msg="Too old docker / docker-py version to run docker_image tests!"
when: not(docker_api_version is version('1.25', '>=')) and (ansible_distribution != 'CentOS' or ansible_distribution_major_version|int > 6)
@@ -8,114 +8,114 @@
image_name: "{{ docker_test_image_simple_1 }}"
block:
- name: Make sure image is not there
docker_image_remove:
community.docker.docker_image_remove:
name: "{{ image_name }}"
force: true
- name: Pull image (check mode)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: amd64
register: present_1_check
check_mode: true
- debug:
- ansible.builtin.debug:
var: present_1_check.diff
- name: Pull image
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: amd64
register: present_1
- debug:
- ansible.builtin.debug:
var: present_1.diff
- name: Pull image (idempotent 1, check mode)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: amd64
pull: always
register: present_2_check
check_mode: true
- debug:
- ansible.builtin.debug:
var: present_2_check.diff
- name: Pull image (idempotent 1)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: amd64
pull: always
register: present_2
- debug:
- ansible.builtin.debug:
var: present_2.diff
- name: Pull image (change, check mode)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: arm64
pull: always
register: present_3_check
check_mode: true
- debug:
- ansible.builtin.debug:
var: present_3_check.diff
- name: Pull image (change)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: arm64
pull: always
register: present_3
- debug:
- ansible.builtin.debug:
var: present_3.diff
- name: Pull image (idempotent 2, check mode)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: arm64
pull: not_present
register: present_4_check
check_mode: true
- debug:
- ansible.builtin.debug:
var: present_4_check.diff
- name: Pull image (idempotent 2)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: arm64
pull: not_present
register: present_4
- debug:
- ansible.builtin.debug:
var: present_4.diff
- name: Pull image (change, check mode)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: amd64
pull: not_present
register: present_5_check
check_mode: true
- debug:
- ansible.builtin.debug:
var: present_5_check.diff
- name: Pull image (change)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ image_name }}"
platform: amd64
pull: not_present
register: present_5
- debug:
- ansible.builtin.debug:
var: present_5.diff
- assert:
- ansible.builtin.assert:
that:
- present_1_check is changed
- present_1_check.actions | length == 1
@@ -169,24 +169,24 @@
always:
- name: cleanup
docker_image_remove:
community.docker.docker_image_remove:
name: "{{ image_name }}"
force: true
- name: Pull image ID (must fail)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ present_1.image.Id }}"
register: fail_1
ignore_errors: true
- name: Pull invalid tag (must fail)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ docker_test_image_hello_world }}"
tag: foo/bar
register: fail_2
ignore_errors: true
- assert:
- ansible.builtin.assert:
that:
- fail_1 is failed
- >-
@@ -6,7 +6,7 @@
- name: Image ID pull tests
block:
- name: Make sure images are not there
docker_image_remove:
community.docker.docker_image_remove:
name: "{{ item }}"
force: true
loop:
@@ -14,26 +14,26 @@
- "sha256:{{ docker_test_image_digest_v2_image_id }}"
- name: Pull image 1
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ docker_test_image_digest_base }}@sha256:{{ docker_test_image_digest_v1 }}"
register: present_1
diff: true
- name: Pull image 1 (idempotent, do pull)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ docker_test_image_digest_base }}@sha256:{{ docker_test_image_digest_v1 }}"
pull: always
register: present_2
diff: true
- name: Pull image 1 (idempotent, do not pull)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ docker_test_image_digest_base }}@sha256:{{ docker_test_image_digest_v1 }}"
pull: not_present
register: present_3
diff: true
- assert:
- ansible.builtin.assert:
that:
- present_1 is changed
- present_1.actions | length == 1
@@ -51,7 +51,7 @@
- present_3.diff.after.id == present_1.diff.after.id
- name: Pull image 2 (check mode)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ docker_test_image_digest_base }}@sha256:{{ docker_test_image_digest_v2 }}"
pull: always
register: present_4
@@ -59,13 +59,13 @@
check_mode: true
- name: Pull image 2
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ docker_test_image_digest_base }}@sha256:{{ docker_test_image_digest_v2 }}"
pull: always
register: present_5
diff: true
- assert:
- ansible.builtin.assert:
that:
- present_4 is changed
- present_4.actions | length == 1
@@ -81,7 +81,7 @@
always:
- name: cleanup
docker_image_remove:
community.docker.docker_image_remove:
name: "{{ item }}"
force: true
loop:
@@ -7,67 +7,67 @@
when: registry_address is defined
block:
- name: Registering image name
set_fact:
ansible.builtin.set_fact:
iname: "{{ name_prefix ~ '-options' }}"
- name: Determining pushed image names
set_fact:
ansible.builtin.set_fact:
hello_world_image_base: "{{ registry_address }}/test/hello-world"
- name: Registering image name
set_fact:
ansible.builtin.set_fact:
inames: "{{ inames + [iname, hello_world_image_base ~ ':latest'] }}"
- name: Make sure image is not there
docker_image_remove:
community.docker.docker_image_remove:
name: "{{ hello_world_image_base }}:latest"
force: true
- name: Make sure we have {{ docker_test_image_hello_world }}
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ docker_test_image_hello_world }}"
diff: true
- name: Tag image
docker_image_tag:
community.docker.docker_image_tag:
name: "{{ docker_test_image_hello_world }}"
repository:
- "{{ hello_world_image_base }}:latest"
- name: Push image to test registry
docker_image_push:
community.docker.docker_image_push:
name: "{{ hello_world_image_base }}:latest"
- name: Get facts of local image
docker_image_info:
community.docker.docker_image_info:
name: "{{ hello_world_image_base }}:latest"
register: facts_1
- name: Make sure image is not there
docker_image_remove:
community.docker.docker_image_remove:
name: "{{ hello_world_image_base }}:latest"
force: true
- name: Get facts of local image (not there)
docker_image_info:
community.docker.docker_image_info:
name: "{{ hello_world_image_base }}:latest"
register: facts_2
- name: Pull image from test registry (check mode)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ hello_world_image_base }}:latest"
register: pull_1_check
diff: true
check_mode: true
- name: Pull image from test registry
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ hello_world_image_base }}:latest"
register: pull_1
diff: true
- name: Pull image from test registry (idempotency, not pulling, check mode)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ hello_world_image_base }}:latest"
pull: not_present
register: pull_2_check
@@ -75,14 +75,14 @@
check_mode: true
- name: Pull image from test registry (idempotency, not pulling)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ hello_world_image_base }}:latest"
pull: not_present
register: pull_2
diff: true
- name: Pull image from test registry (idempotency, pulling, check mode)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ hello_world_image_base }}:latest"
pull: always
register: pull_3_check
@@ -90,18 +90,18 @@
check_mode: true
- name: Pull image from test registry (idempotency, pulling)
docker_image_pull:
community.docker.docker_image_pull:
name: "{{ hello_world_image_base }}:latest"
pull: always
register: pull_3
diff: true
- name: Get facts of local image (present)
docker_image_info:
community.docker.docker_image_info:
name: "{{ hello_world_image_base }}:latest"
register: facts_3
- assert:
- ansible.builtin.assert:
that:
- pull_1_check is changed
- pull_1_check.diff.before.exists is false