Address some pylint issues (#1155)

* Address cyclic-import.

* Address redefined-builtin.

* Address redefined-argument-from-local.

* Address many redefined-outer-name.

* Address pointless-string-statement.

* No longer needed due to separate bugfix.

* Address useless-return.

* Address possibly-used-before-assignment.

* Add TODOs.

* Address super-init-not-called.

* Address function-redefined.

* Address unspecified-encoding.

* Clean up more imports.

tests/unit/plugins/modules/test_docker_container_copy_into.py

@@ -15,7 +15,7 @@ from ansible_collections.community.docker.plugins.modules.docker_container_copy_
 
 
 @pytest.mark.parametrize(
-    "input, expected",
+    "value, expected",
     [
         ("0777", 0o777),
         ("777", 0o777),
@@ -32,13 +32,13 @@ from ansible_collections.community.docker.plugins.modules.docker_container_copy_
         ("-1", -1),
     ],
 )
-def test_parse_string(input, expected):
-    assert parse_modern(input) == expected
-    assert parse_octal_string_only(input) == expected
+def test_parse_string(value, expected):
+    assert parse_modern(value) == expected
+    assert parse_octal_string_only(value) == expected
 
 
 @pytest.mark.parametrize(
-    "input",
+    "value",
     [
         0o777,
         0o755,
@@ -47,14 +47,14 @@ def test_parse_string(input, expected):
         123456789012345678901234567890123456789012345678901234567890,
     ],
 )
-def test_parse_int(input):
-    assert parse_modern(input) == input
-    with pytest.raises(TypeError, match=f"^must be an octal string, got {input}L?$"):
-        parse_octal_string_only(input)
+def test_parse_int(value):
+    assert parse_modern(value) == value
+    with pytest.raises(TypeError, match=f"^must be an octal string, got {value}L?$"):
+        parse_octal_string_only(value)
 
 
 @pytest.mark.parametrize(
-    "input",
+    "value",
     [
         1.0,
         755.5,
@@ -62,23 +62,23 @@ def test_parse_int(input):
         {},
     ],
 )
-def test_parse_bad_type(input):
+def test_parse_bad_type(value):
     with pytest.raises(TypeError, match="^must be an octal string or an integer, got "):
-        parse_modern(input)
+        parse_modern(value)
     with pytest.raises(TypeError, match="^must be an octal string, got "):
-        parse_octal_string_only(input)
+        parse_octal_string_only(value)
 
 
 @pytest.mark.parametrize(
-    "input",
+    "value",
     [
         "foo",
         "8",
         "9",
     ],
 )
-def test_parse_bad_value(input):
+def test_parse_bad_value(value):
     with pytest.raises(ValueError):
-        parse_modern(input)
+        parse_modern(value)
     with pytest.raises(ValueError):
-        parse_octal_string_only(input)
+        parse_octal_string_only(value)

tests/unit/plugins/modules/test_docker_image_build.py

@@ -14,7 +14,7 @@ from ansible_collections.community.docker.plugins.modules.docker_image_build imp
 
 
 @pytest.mark.parametrize(
-    "input, expected",
+    "value, expected",
     [
         ("", ""),
         (" ", '" "'),
@@ -23,5 +23,5 @@ from ansible_collections.community.docker.plugins.modules.docker_image_build imp
         ('\rhello, "hi" !\n', '"\rhello, ""hi"" !\n"'),
     ],
 )
-def test__quote_csv(input, expected):
-    assert _quote_csv(input) == expected
+def test__quote_csv(value, expected):
+    assert _quote_csv(value) == expected