Address some pylint issues (#1155)

* Address cyclic-import.

* Address redefined-builtin.

* Address redefined-argument-from-local.

* Address many redefined-outer-name.

* Address pointless-string-statement.

* No longer needed due to separate bugfix.

* Address useless-return.

* Address possibly-used-before-assignment.

* Add TODOs.

* Address super-init-not-called.

* Address function-redefined.

* Address unspecified-encoding.

* Clean up more imports.

plugins/module_utils/_api/utils/build.py

@@ -271,7 +271,7 @@ def process_dockerfile(dockerfile, path):
         0
     ] or os.path.relpath(abs_dockerfile, path).startswith(".."):
         # Dockerfile not in context - read data to insert into tar later
-        with open(abs_dockerfile) as df:
+        with open(abs_dockerfile, "rt", encoding="utf-8") as df:
             return (f".dockerfile.{random.getrandbits(160):x}", df.read())
 
     # Dockerfile is inside the context - return path relative to context root

plugins/module_utils/_api/utils/config.py

@@ -80,7 +80,7 @@ def load_general_config(config_path=None):
         return {}
 
     try:
-        with open(config_file) as f:
+        with open(config_file, "rt", encoding="utf-8") as f:
             return json.load(f)
     except (IOError, ValueError) as e:
         # In the case of a legacy `.dockercfg` file, we will not

plugins/module_utils/_api/utils/fnmatch.py

@@ -10,9 +10,6 @@
 # Note that this module util is **PRIVATE** to the collection. It can have breaking changes at any time.
 # Do not use this from other collections or standalone plugins/modules!
 
-from __future__ import annotations
-
-
 """Filename matching with shell patterns.
 
 fnmatch(FILENAME, PATTERN) matches according to the local convention.
@@ -25,6 +22,8 @@ The function translate(PATTERN) returns a regular expression
 corresponding to PATTERN.  (It does not compile it.)
 """
 
+from __future__ import annotations
+
 import re
 
 

plugins/module_utils/_api/utils/utils.py

@@ -452,7 +452,7 @@ def parse_env_file(env_file):
     """
     environment = {}
 
-    with open(env_file, "r") as f:
+    with open(env_file, "rt", encoding="utf-8") as f:
         for line in f:
 
             if line[0] == "#":