Address some pylint issues (#1155)

* Address cyclic-import.

* Address redefined-builtin.

* Address redefined-argument-from-local.

* Address many redefined-outer-name.

* Address pointless-string-statement.

* No longer needed due to separate bugfix.

* Address useless-return.

* Address possibly-used-before-assignment.

* Add TODOs.

* Address super-init-not-called.

* Address function-redefined.

* Address unspecified-encoding.

* Clean up more imports.

plugins/module_utils/_api/context/api.py

@@ -151,7 +151,7 @@ class ContextAPI(object):
                 if filename == METAFILE:
                     filepath = os.path.join(dirname, filename)
                     try:
-                        with open(filepath, "r") as f:
+                        with open(filepath, "rt", encoding="utf-8") as f:
                             data = json.load(f)
                         name = data["Name"]
                         if name == "default":

plugins/module_utils/_api/context/config.py

@@ -32,7 +32,7 @@ def get_current_context_name_with_source():
     docker_cfg_path = find_config_file()
     if docker_cfg_path:
         try:
-            with open(docker_cfg_path) as f:
+            with open(docker_cfg_path, "rt", encoding="utf-8") as f:
                 return (
                     json.load(f).get("currentContext", "default"),
                     f"configuration file {docker_cfg_path}",
@@ -53,7 +53,7 @@ def write_context_name_to_docker_config(name=None):
     config = {}
     if docker_cfg_path:
         try:
-            with open(docker_cfg_path) as f:
+            with open(docker_cfg_path, "rt", encoding="utf-8") as f:
                 config = json.load(f)
         except Exception as e:
             return e
@@ -67,7 +67,7 @@ def write_context_name_to_docker_config(name=None):
     if not docker_cfg_path:
         docker_cfg_path = get_default_config_file()
     try:
-        with open(docker_cfg_path, "w") as f:
+        with open(docker_cfg_path, "wt", encoding="utf-8") as f:
             json.dump(config, f, indent=4)
     except Exception as e:
         return e

plugins/module_utils/_api/context/context.py

@@ -133,7 +133,7 @@ class Context(object):
 
         metadata = {}
         try:
-            with open(meta_file) as f:
+            with open(meta_file, "rt", encoding="utf-8") as f:
                 metadata = json.load(f)
         except (OSError, KeyError, ValueError) as e:
             # unknown format
@@ -189,7 +189,7 @@ class Context(object):
         meta_dir = get_meta_dir(self.name)
         if not os.path.isdir(meta_dir):
             os.makedirs(meta_dir)
-        with open(get_meta_file(self.name), "w") as f:
+        with open(get_meta_file(self.name), "wt", encoding="utf-8") as f:
             f.write(json.dumps(self.Metadata))
 
         tls_dir = get_tls_dir(self.name)