From a1b73a36a89bc510756ed954648205e88c9950e8 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Tue, 21 Oct 2025 07:48:40 +0200 Subject: [PATCH] Fix split_port() without returning to previous type chaos. --- plugins/module_utils/_api/utils/ports.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/module_utils/_api/utils/ports.py b/plugins/module_utils/_api/utils/ports.py index a033c450..eab15bd0 100644 --- a/plugins/module_utils/_api/utils/ports.py +++ b/plugins/module_utils/_api/utils/ports.py @@ -119,12 +119,12 @@ def split_port( host: str | None = parts["host"] proto: str = parts["proto"] or "" int_p: str = parts["int"] - ext_p: str | None = parts["ext"] or None + ext_p: str = parts["ext"] internal: list[str] = port_range(int_p, parts["int_end"], proto) # type: ignore - external = port_range(ext_p, parts["ext_end"], "", len(internal) == 1) + external = port_range(ext_p or None, parts["ext_end"], "", len(internal) == 1) if host is None: - if external is not None and len(internal) != len(external): + if (external is not None and len(internal) != len(external)) or ext_p == "": raise ValueError("Port ranges don't match in length") return internal, external external_or_none: Sequence[str | None]