Add ansible-lint to CI (#1181)

* Improve Ansible code.

* Add some ansible-lint ignores.

* Add ansible-lint to CI.
This commit is contained in:
Felix Fontein
2025-10-25 11:07:40 +02:00
committed by GitHub
parent b24bce77b6
commit 95bdce75e6
35 changed files with 123 additions and 85 deletions
@@ -27,7 +27,7 @@
- name: Create a Swarm cluster
community.docker.docker_swarm:
state: present
advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
advertise_addr: "{{ ansible_default_ipv4.address | default('127.0.0.1') }}"
- ansible.builtin.include_tasks: run-test.yml
with_fileglob:
@@ -47,7 +47,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
filename: "/tmp/{{ config_name_1 }}.txt"
register: configs_1
@@ -72,7 +72,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
filename: "/tmp/{{ config_name_1 }}.txt"
- config_name: "{{ config_name_2 }}"
@@ -89,7 +89,7 @@
configs:
- config_name: "{{ config_name_1 }}"
filename: "/tmp/{{ config_name_1 }}.txt"
- config_id: "{{ config_result_2.config_id|default('') }}"
- config_id: "{{ config_result_2.config_id | default('') }}"
config_name: "{{ config_name_2 }}"
filename: "/tmp/{{ config_name_2 }}.txt"
register: configs_4
@@ -215,7 +215,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
uid: 1000
register: configs_1
@@ -228,7 +228,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
uid: 1000
register: configs_2
@@ -241,7 +241,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
uid: 1002
register: configs_3
@@ -254,7 +254,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
uid: "1001"
register: configs_4
@@ -267,7 +267,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
uid: "1001"
register: configs_5
@@ -305,7 +305,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
gid: 1000
register: configs_1
@@ -318,7 +318,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
gid: 1000
register: configs_2
@@ -331,7 +331,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
gid: 1002
register: configs_3
@@ -344,7 +344,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
gid: "1001"
register: configs_4
@@ -357,7 +357,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
gid: "1001"
register: configs_5
@@ -394,7 +394,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
mode: "0600"
register: configs_1
@@ -407,7 +407,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
mode: "0600"
register: configs_2
@@ -420,7 +420,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
configs:
- config_id: "{{ config_result_1.config_id|default('') }}"
- config_id: "{{ config_result_1.config_id | default('') }}"
config_name: "{{ config_name_1 }}"
mode: "0777"
register: configs_3
@@ -96,7 +96,7 @@
- name: fake image key as it is not predictable
ansible.builtin.set_fact:
ansible_docker_service_output: "{{ output.swarm_service|combine({'image': docker_test_image_busybox}) }}"
ansible_docker_service_output: "{{ output.swarm_service | combine({'image': docker_test_image_busybox}) }}"
- name: assert service matches expectations
ansible.builtin.assert:
@@ -47,7 +47,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
filename: "/run/secrets/{{ secret_name_1 }}.txt"
register: secrets_1
@@ -72,7 +72,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
filename: "/run/secrets/{{ secret_name_1 }}.txt"
- secret_name: "{{ secret_name_2 }}"
@@ -89,7 +89,7 @@
secrets:
- secret_name: "{{ secret_name_1 }}"
filename: "/run/secrets/{{ secret_name_1 }}.txt"
- secret_id: "{{ secret_result_2.secret_id|default('') }}"
- secret_id: "{{ secret_result_2.secret_id | default('') }}"
secret_name: "{{ secret_name_2 }}"
filename: "/run/secrets/{{ secret_name_2 }}.txt"
register: secrets_4
@@ -214,7 +214,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
uid: 1000
register: secrets_1
@@ -227,7 +227,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
uid: 1000
register: secrets_2
@@ -240,7 +240,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
uid: 1002
register: secrets_3
@@ -253,7 +253,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
uid: "1001"
register: secrets_4
@@ -266,7 +266,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
uid: "1001"
register: secrets_5
@@ -303,7 +303,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
gid: 1001
register: secrets_1
@@ -316,7 +316,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
gid: 1001
register: secrets_2
@@ -329,7 +329,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
gid: 1002
register: secrets_3
@@ -342,7 +342,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
gid: "1003"
register: secrets_4
@@ -355,7 +355,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
gid: "1003"
register: secrets_5
@@ -392,7 +392,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
mode: "0600"
register: secrets_1
@@ -405,7 +405,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
mode: "0600"
register: secrets_2
@@ -418,7 +418,7 @@
resolve_image: false
command: '/bin/sh -v -c "sleep 10m"'
secrets:
- secret_id: "{{ secret_result_1.secret_id|default('') }}"
- secret_id: "{{ secret_result_1.secret_id | default('') }}"
secret_name: "{{ secret_name_1 }}"
mode: "0777"
register: secrets_3