Add ansible-lint to CI (#1181)

* Improve Ansible code.

* Add some ansible-lint ignores.

* Add ansible-lint to CI.

tests/integration/targets/docker_swarm/tasks/tests/basic.yml

@@ -10,7 +10,7 @@
 ## Errors ##########################################################
 ####################################################################
 - name: Test parameters with state=join
-  community.docker.docker_swarm:
+  community.docker.docker_swarm:  # noqa: args[module]
     state: join
   ignore_errors: true
   register: output
@@ -22,7 +22,7 @@
       - 'output.msg == "state is join but all of the following are missing: remote_addrs, join_token"'
 
 - name: Test parameters with state=remove
-  community.docker.docker_swarm:
+  community.docker.docker_swarm:  # noqa: args[module]
     state: remove
   ignore_errors: true
   register: output
@@ -40,7 +40,7 @@
 - name: Create a Swarm cluster (check mode)
   community.docker.docker_swarm:
     state: present
-    advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
+    advertise_addr: "{{ ansible_default_ipv4.address | default('127.0.0.1') }}"
   check_mode: true
   diff: true
   register: output_1
@@ -48,21 +48,21 @@
 - name: Create a Swarm cluster
   community.docker.docker_swarm:
     state: present
-    advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
+    advertise_addr: "{{ ansible_default_ipv4.address | default('127.0.0.1') }}"
   diff: true
   register: output_2
 
 - name: Create a Swarm cluster (idempotent)
   community.docker.docker_swarm:
     state: present
-    advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
+    advertise_addr: "{{ ansible_default_ipv4.address | default('127.0.0.1') }}"
   diff: true
   register: output_3
 
 - name: Create a Swarm cluster (idempotent, check mode)
   community.docker.docker_swarm:
     state: present
-    advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
+    advertise_addr: "{{ ansible_default_ipv4.address | default('127.0.0.1') }}"
   check_mode: true
   diff: true
   register: output_4
@@ -70,7 +70,7 @@
 - name: Create a Swarm cluster (force re-create)
   community.docker.docker_swarm:
     state: present
-    advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
+    advertise_addr: "{{ ansible_default_ipv4.address | default('127.0.0.1') }}"
     force: true
   diff: true
   register: output_5
@@ -78,7 +78,7 @@
 - name: Create a Swarm cluster (force re-create, check mode)
   community.docker.docker_swarm:
     state: present
-    advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
+    advertise_addr: "{{ ansible_default_ipv4.address | default('127.0.0.1') }}"
     force: true
   check_mode: true
   diff: true

tests/integration/targets/docker_swarm/tasks/tests/options-ca.yml

@@ -58,7 +58,7 @@
       register: ansible_keys
     - name: signing_ca_cert and signing_ca_key (check mode)
       community.docker.docker_swarm:
-        advertise_addr: '{{ansible_default_ipv4.address | default("127.0.0.1")}}'
+        advertise_addr: '{{ ansible_default_ipv4.address | default("127.0.0.1") }}'
         state: present
         signing_ca_cert: '{{ ansible_certificates.results[0].content | b64decode }}'
         signing_ca_key: '{{ ansible_keys.results[0].content | b64decode }}'
@@ -69,7 +69,7 @@
       ignore_errors: true
     - name: signing_ca_cert and signing_ca_key
       community.docker.docker_swarm:
-        advertise_addr: '{{ansible_default_ipv4.address | default("127.0.0.1")}}'
+        advertise_addr: '{{ ansible_default_ipv4.address | default("127.0.0.1") }}'
         state: present
         signing_ca_cert: '{{ ansible_certificates.results[0].content | b64decode }}'
         signing_ca_key: '{{ ansible_keys.results[0].content | b64decode }}'

tests/integration/targets/docker_swarm/tasks/tests/options.yml

@@ -9,7 +9,7 @@
 - name: Create a Swarm cluster
   community.docker.docker_swarm:
     state: present
-    advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
+    advertise_addr: "{{ ansible_default_ipv4.address | default('127.0.0.1') }}"
     name: default
   diff: true
 
@@ -72,7 +72,7 @@
   community.docker.docker_swarm:
     state: present
     force: true
-    advertise_addr: "{{ansible_default_ipv4.address | default('127.0.0.1')}}"
+    advertise_addr: "{{ ansible_default_ipv4.address | default('127.0.0.1') }}"
     autolock_managers: true
   diff: true
   register: output_7