Run registry tests only when registry is present. (#729)

This commit is contained in:
Felix Fontein 2023-12-29 11:27:49 +01:00 committed by GitHub
parent b1dfe49e7d
commit 8ee0452776
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -9,8 +9,8 @@
- name: Determining pushed image names - name: Determining pushed image names
set_fact: set_fact:
hello_world_image_base: "{{ registry_address }}/test/hello-world" hello_world_image_base: "{{ registry_address | default('localhost') }}/test/hello-world"
test_image_base: "{{ registry_address }}/test/{{ iname }}" test_image_base: "{{ registry_address | default('localhost') }}/test/{{ iname }}"
- name: Registering image name - name: Registering image name
set_fact: set_fact:
@ -20,179 +20,182 @@
## interact with test registry ##################################### ## interact with test registry #####################################
#################################################################### ####################################################################
- name: Make sure image is not there - name: Run registry tests only when registry is present
docker_image: when: registry_address is defined
name: "{{ hello_world_image_base }}:latest" block:
state: absent - name: Make sure image is not there
force_absent: true docker_image:
name: "{{ hello_world_image_base }}:latest"
state: absent
force_absent: true
- name: Make sure we have {{ docker_test_image_hello_world }} - name: Make sure we have {{ docker_test_image_hello_world }}
docker_image: docker_image:
name: "{{ docker_test_image_hello_world }}" name: "{{ docker_test_image_hello_world }}"
source: pull source: pull
- name: Push image to test registry - name: Push image to test registry
docker_image: docker_image:
name: "{{ docker_test_image_hello_world }}" name: "{{ docker_test_image_hello_world }}"
repository: "{{ hello_world_image_base }}:latest" repository: "{{ hello_world_image_base }}:latest"
push: true push: true
source: local source: local
register: push_1 register: push_1
- name: Push image to test registry (idempotent) - name: Push image to test registry (idempotent)
docker_image: docker_image:
name: "{{ docker_test_image_hello_world }}" name: "{{ docker_test_image_hello_world }}"
repository: "{{ hello_world_image_base }}:latest" repository: "{{ hello_world_image_base }}:latest"
push: true push: true
source: local source: local
register: push_2 register: push_2
- name: Push image to test registry (force, still idempotent) - name: Push image to test registry (force, still idempotent)
docker_image: docker_image:
name: "{{ docker_test_image_hello_world }}" name: "{{ docker_test_image_hello_world }}"
repository: "{{ hello_world_image_base }}:latest" repository: "{{ hello_world_image_base }}:latest"
push: true push: true
source: local source: local
force_tag: true force_tag: true
register: push_3 register: push_3
- assert: - assert:
that: that:
- push_1 is changed - push_1 is changed
- push_2 is not changed - push_2 is not changed
- push_3 is not changed - push_3 is not changed
- name: Get facts of local image - name: Get facts of local image
docker_image_info: docker_image_info:
name: "{{ hello_world_image_base }}:latest" name: "{{ hello_world_image_base }}:latest"
register: facts_1 register: facts_1
- name: Make sure image is not there - name: Make sure image is not there
docker_image: docker_image:
name: "{{ hello_world_image_base }}:latest" name: "{{ hello_world_image_base }}:latest"
state: absent state: absent
force_absent: true force_absent: true
- name: Get facts of local image (absent) - name: Get facts of local image (absent)
docker_image_info: docker_image_info:
name: "{{ hello_world_image_base }}:latest" name: "{{ hello_world_image_base }}:latest"
register: facts_2 register: facts_2
- name: Pull image from test registry - name: Pull image from test registry
docker_image: docker_image:
name: "{{ hello_world_image_base }}:latest" name: "{{ hello_world_image_base }}:latest"
state: present state: present
source: pull source: pull
register: pull_1 register: pull_1
- name: Pull image from test registry (idempotency) - name: Pull image from test registry (idempotency)
docker_image: docker_image:
name: "{{ hello_world_image_base }}:latest" name: "{{ hello_world_image_base }}:latest"
state: present state: present
source: pull source: pull
register: pull_2 register: pull_2
- name: Get facts of local image (present) - name: Get facts of local image (present)
docker_image_info: docker_image_info:
name: "{{ hello_world_image_base }}:latest" name: "{{ hello_world_image_base }}:latest"
register: facts_3 register: facts_3
- assert: - assert:
that: that:
- pull_1 is changed - pull_1 is changed
- pull_2 is not changed - pull_2 is not changed
- facts_1.images | length == 1 - facts_1.images | length == 1
- facts_2.images | length == 0 - facts_2.images | length == 0
- facts_3.images | length == 1 - facts_3.images | length == 1
- name: Pull image from test registry (with digest) - name: Pull image from test registry (with digest)
docker_image: docker_image:
name: "{{ facts_3.images[0].RepoDigests[0] }}" name: "{{ facts_3.images[0].RepoDigests[0] }}"
state: present state: present
source: pull source: pull
force_source: true force_source: true
register: pull_digest register: pull_digest
- name: Make sure that changed is still false - name: Make sure that changed is still false
assert: assert:
that: that:
- pull_digest is not changed - pull_digest is not changed
- name: Tag different image with new tag - name: Tag different image with new tag
docker_image: docker_image:
name: "{{ docker_test_image_alpine_different }}" name: "{{ docker_test_image_alpine_different }}"
repository: "{{ hello_world_image_base }}:newtag" repository: "{{ hello_world_image_base }}:newtag"
push: false push: false
source: pull source: pull
- name: Push different image with new tag - name: Push different image with new tag
docker_image: docker_image:
name: "{{ hello_world_image_base }}" name: "{{ hello_world_image_base }}"
repository: "{{ hello_world_image_base }}" repository: "{{ hello_world_image_base }}"
tag: newtag tag: newtag
push: true push: true
source: local source: local
register: push_1_different register: push_1_different
- name: Push different image with new tag (idempotent) - name: Push different image with new tag (idempotent)
docker_image: docker_image:
name: "{{ hello_world_image_base }}" name: "{{ hello_world_image_base }}"
repository: "{{ hello_world_image_base }}" repository: "{{ hello_world_image_base }}"
tag: newtag tag: newtag
push: true push: true
source: local source: local
register: push_2_different register: push_2_different
- assert: - assert:
that: that:
- push_1_different is changed - push_1_different is changed
- push_2_different is not changed - push_2_different is not changed
- name: Tag same image with new tag - name: Tag same image with new tag
docker_image: docker_image:
name: "{{ docker_test_image_alpine_different }}" name: "{{ docker_test_image_alpine_different }}"
repository: "{{ hello_world_image_base }}:newtag2" repository: "{{ hello_world_image_base }}:newtag2"
push: false push: false
source: pull source: pull
- name: Push same image with new tag - name: Push same image with new tag
docker_image: docker_image:
name: "{{ hello_world_image_base }}" name: "{{ hello_world_image_base }}"
repository: "{{ hello_world_image_base }}" repository: "{{ hello_world_image_base }}"
tag: newtag2 tag: newtag2
push: true push: true
source: local source: local
register: push_1_same register: push_1_same
- name: Push same image with new tag (idempotent) - name: Push same image with new tag (idempotent)
docker_image: docker_image:
name: "{{ hello_world_image_base }}" name: "{{ hello_world_image_base }}"
repository: "{{ hello_world_image_base }}" repository: "{{ hello_world_image_base }}"
tag: newtag2 tag: newtag2
push: true push: true
source: local source: local
register: push_2_same register: push_2_same
- assert: - assert:
that: that:
# NOTE: This should be: # NOTE: This should be:
# - push_1_same is changed # - push_1_same is changed
# Unfortunately docker does *NOT* report whether the tag already existed or not. # Unfortunately docker does *NOT* report whether the tag already existed or not.
# Here are the logs returned by client.push() for both tasks (which are exactly the same): # Here are the logs returned by client.push() for both tasks (which are exactly the same):
# push_1_same: # push_1_same:
# {"status": "The push refers to repository [localhost:32796/test/hello-world]"}, # {"status": "The push refers to repository [localhost:32796/test/hello-world]"},
# {"id": "3fc64803ca2d", "progressDetail": {}, "status": "Preparing"}, # {"id": "3fc64803ca2d", "progressDetail": {}, "status": "Preparing"},
# {"id": "3fc64803ca2d", "progressDetail": {}, "status": "Layer already exists"}, # {"id": "3fc64803ca2d", "progressDetail": {}, "status": "Layer already exists"},
# {"status": "newtag2: digest: sha256:92251458088c638061cda8fd8b403b76d661a4dc6b7ee71b6affcf1872557b2b size: 528"}, # {"status": "newtag2: digest: sha256:92251458088c638061cda8fd8b403b76d661a4dc6b7ee71b6affcf1872557b2b size: 528"},
# {"aux": {"Digest": "sha256:92251458088c638061cda8fd8b403b76d661a4dc6b7ee71b6affcf1872557b2b", "Size": 528, "Tag": "newtag2"}, "progressDetail": {}} # {"aux": {"Digest": "sha256:92251458088c638061cda8fd8b403b76d661a4dc6b7ee71b6affcf1872557b2b", "Size": 528, "Tag": "newtag2"}, "progressDetail": {}}
# push_2_same: # push_2_same:
# {"status": "The push refers to repository [localhost:32796/test/hello-world]"}, # {"status": "The push refers to repository [localhost:32796/test/hello-world]"},
# {"id": "3fc64803ca2d", "progressDetail": {}, "status": "Preparing"}, # {"id": "3fc64803ca2d", "progressDetail": {}, "status": "Preparing"},
# {"id": "3fc64803ca2d", "progressDetail": {}, "status": "Layer already exists"}, # {"id": "3fc64803ca2d", "progressDetail": {}, "status": "Layer already exists"},
# {"status": "newtag2: digest: sha256:92251458088c638061cda8fd8b403b76d661a4dc6b7ee71b6affcf1872557b2b size: 528"}, # {"status": "newtag2: digest: sha256:92251458088c638061cda8fd8b403b76d661a4dc6b7ee71b6affcf1872557b2b size: 528"},
# {"aux": {"Digest": "sha256:92251458088c638061cda8fd8b403b76d661a4dc6b7ee71b6affcf1872557b2b", "Size": 528, "Tag": "newtag2"}, "progressDetail": {}} # {"aux": {"Digest": "sha256:92251458088c638061cda8fd8b403b76d661a4dc6b7ee71b6affcf1872557b2b", "Size": 528, "Tag": "newtag2"}, "progressDetail": {}}
- push_1_same is not changed - push_1_same is not changed
- push_2_same is not changed - push_2_same is not changed
#################################################################### ####################################################################
## repository ###################################################### ## repository ######################################################