Run registry tests only when registry is present. (#729)

tests/integration/targets/docker_image/tasks/tests/docker_image.yml

@@ -9,8 +9,8 @@
 
 - name: Determining pushed image names
   set_fact:
-    hello_world_image_base: "{{ registry_address }}/test/hello-world"
+    hello_world_image_base: "{{ registry_address | default('localhost') }}/test/hello-world"
-    test_image_base: "{{ registry_address }}/test/{{ iname }}"
+    test_image_base: "{{ registry_address | default('localhost') }}/test/{{ iname }}"
 
 - name: Registering image name
   set_fact:
@@ -20,18 +20,21 @@
 ## interact with test registry #####################################
 ####################################################################
 
-- name: Make sure image is not there
+- name: Run registry tests only when registry is present
+  when: registry_address is defined
+  block:
+    - name: Make sure image is not there
       docker_image:
         name: "{{ hello_world_image_base }}:latest"
         state: absent
         force_absent: true
 
-- name: Make sure we have {{ docker_test_image_hello_world }}
+    - name: Make sure we have {{ docker_test_image_hello_world }}
       docker_image:
         name: "{{ docker_test_image_hello_world }}"
         source: pull
 
-- name: Push image to test registry
+    - name: Push image to test registry
       docker_image:
         name: "{{ docker_test_image_hello_world }}"
         repository: "{{ hello_world_image_base }}:latest"
@@ -39,7 +42,7 @@
         source: local
       register: push_1
 
-- name: Push image to test registry (idempotent)
+    - name: Push image to test registry (idempotent)
       docker_image:
         name: "{{ docker_test_image_hello_world }}"
         repository: "{{ hello_world_image_base }}:latest"
@@ -47,7 +50,7 @@
         source: local
       register: push_2
 
-- name: Push image to test registry (force, still idempotent)
+    - name: Push image to test registry (force, still idempotent)
       docker_image:
         name: "{{ docker_test_image_hello_world }}"
         repository: "{{ hello_world_image_base }}:latest"
@@ -56,48 +59,48 @@
         force_tag: true
       register: push_3
 
-- assert:
+    - assert:
         that:
         - push_1 is changed
         - push_2 is not changed
         - push_3 is not changed
 
-- name: Get facts of local image
+    - name: Get facts of local image
       docker_image_info:
         name: "{{ hello_world_image_base }}:latest"
       register: facts_1
 
-- name: Make sure image is not there
+    - name: Make sure image is not there
       docker_image:
         name: "{{ hello_world_image_base }}:latest"
         state: absent
         force_absent: true
 
-- name: Get facts of local image (absent)
+    - name: Get facts of local image (absent)
       docker_image_info:
         name: "{{ hello_world_image_base }}:latest"
       register: facts_2
 
-- name: Pull image from test registry
+    - name: Pull image from test registry
       docker_image:
         name: "{{ hello_world_image_base }}:latest"
         state: present
         source: pull
       register: pull_1
 
-- name: Pull image from test registry (idempotency)
+    - name: Pull image from test registry (idempotency)
       docker_image:
         name: "{{ hello_world_image_base }}:latest"
         state: present
         source: pull
       register: pull_2
 
-- name: Get facts of local image (present)
+    - name: Get facts of local image (present)
       docker_image_info:
         name: "{{ hello_world_image_base }}:latest"
       register: facts_3
 
-- assert:
+    - assert:
         that:
         - pull_1 is changed
         - pull_2 is not changed
@@ -105,7 +108,7 @@
         - facts_2.images | length == 0
         - facts_3.images | length == 1
 
-- name: Pull image from test registry (with digest)
+    - name: Pull image from test registry (with digest)
       docker_image:
         name: "{{ facts_3.images[0].RepoDigests[0] }}"
         state: present
@@ -113,19 +116,19 @@
         force_source: true
       register: pull_digest
 
-- name: Make sure that changed is still false
+    - name: Make sure that changed is still false
       assert:
         that:
           - pull_digest is not changed
 
-- name: Tag different image with new tag
+    - name: Tag different image with new tag
       docker_image:
         name: "{{ docker_test_image_alpine_different }}"
         repository: "{{ hello_world_image_base }}:newtag"
         push: false
         source: pull
 
-- name: Push different image with new tag
+    - name: Push different image with new tag
       docker_image:
         name: "{{ hello_world_image_base }}"
         repository: "{{ hello_world_image_base }}"
@@ -134,7 +137,7 @@
         source: local
       register: push_1_different
 
-- name: Push different image with new tag (idempotent)
+    - name: Push different image with new tag (idempotent)
       docker_image:
         name: "{{ hello_world_image_base }}"
         repository: "{{ hello_world_image_base }}"
@@ -143,19 +146,19 @@
         source: local
       register: push_2_different
 
-- assert:
+    - assert:
         that:
         - push_1_different is changed
         - push_2_different is not changed
 
-- name: Tag same image with new tag
+    - name: Tag same image with new tag
       docker_image:
         name: "{{ docker_test_image_alpine_different }}"
         repository: "{{ hello_world_image_base }}:newtag2"
         push: false
         source: pull
 
-- name: Push same image with new tag
+    - name: Push same image with new tag
       docker_image:
         name: "{{ hello_world_image_base }}"
         repository: "{{ hello_world_image_base }}"
@@ -164,7 +167,7 @@
         source: local
       register: push_1_same
 
-- name: Push same image with new tag (idempotent)
+    - name: Push same image with new tag (idempotent)
       docker_image:
         name: "{{ hello_world_image_base }}"
         repository: "{{ hello_world_image_base }}"
@@ -173,7 +176,7 @@
         source: local
       register: push_2_same
 
-- assert:
+    - assert:
         that:
         # NOTE: This should be:
         #   - push_1_same is changed