diff --git a/.pylintrc b/.pylintrc index 8f0bddaf..c0efa2f0 100644 --- a/.pylintrc +++ b/.pylintrc @@ -389,7 +389,6 @@ disable=raw-checker-failed, not-an-iterable, # TODO: needs better typing info protected-access, redefined-outer-name, # needed for test fixtures - simplifiable-if-expression, subprocess-popen-preexec-fn, unexpected-keyword-arg, unnecessary-dunder-call, diff --git a/plugins/connection/docker_api.py b/plugins/connection/docker_api.py index 754687bb..822eb67e 100644 --- a/plugins/connection/docker_api.py +++ b/plugins/connection/docker_api.py @@ -239,7 +239,7 @@ class Connection(ConnectionBase): host=self.get_option("remote_addr"), ) - need_stdin = True if (in_data is not None) or do_become else False + need_stdin = bool((in_data is not None) or do_become) data = { "Container": self.get_option("remote_addr"), diff --git a/plugins/module_utils/_module_container/module.py b/plugins/module_utils/_module_container/module.py index 535ed875..f9b630db 100644 --- a/plugins/module_utils/_module_container/module.py +++ b/plugins/module_utils/_module_container/module.py @@ -42,7 +42,7 @@ class Container(DockerBaseClass): @property def exists(self): - return True if self.container else False + return bool(self.container) @property def removing(self): diff --git a/plugins/modules/docker_container_info.py b/plugins/modules/docker_container_info.py index 077afe63..648e5dce 100644 --- a/plugins/modules/docker_container_info.py +++ b/plugins/modules/docker_container_info.py @@ -101,7 +101,7 @@ def main(): client.module.exit_json( changed=False, - exists=(True if container else False), + exists=bool(container), container=container, ) except DockerException as e: diff --git a/plugins/modules/docker_context_info.py b/plugins/modules/docker_context_info.py index 496c8e81..af33a0fc 100644 --- a/plugins/modules/docker_context_info.py +++ b/plugins/modules/docker_context_info.py @@ -204,10 +204,6 @@ def tls_context_to_json(context): } -def to_bool(value): - return True if value else False - - def context_to_json(context, current): module_config = {} if "docker" in context.endpoints: @@ -240,7 +236,7 @@ def context_to_json(context, current): module_config["validate_certs"] = tls_cfg.verify module_config["tls"] = True else: - module_config["tls"] = to_bool(endpoint.get("SkipTLSVerify")) + module_config["tls"] = bool(endpoint.get("SkipTLSVerify")) return { "current": current, "name": context.name, diff --git a/plugins/modules/docker_network_info.py b/plugins/modules/docker_network_info.py index 52d4848f..cff0c986 100644 --- a/plugins/modules/docker_network_info.py +++ b/plugins/modules/docker_network_info.py @@ -122,7 +122,7 @@ def main(): client.module.exit_json( changed=False, - exists=(True if network else False), + exists=bool(network), network=network, ) except DockerException as e: diff --git a/plugins/modules/docker_volume_info.py b/plugins/modules/docker_volume_info.py index e0f99a50..25a9c77d 100644 --- a/plugins/modules/docker_volume_info.py +++ b/plugins/modules/docker_volume_info.py @@ -106,7 +106,7 @@ def main(): client.module.exit_json( changed=False, - exists=(True if volume else False), + exists=bool(volume), volume=volume, ) except DockerException as e: