diff --git a/changelogs/fragments/1152-fix.yml b/changelogs/fragments/1152-fix.yml new file mode 100644 index 00000000..e37289d6 --- /dev/null +++ b/changelogs/fragments/1152-fix.yml @@ -0,0 +1,3 @@ +bugfixes: + - "docker_api connection plugin - fix bug that could lead to loss of data when waiting for ``become`` plugin prompt (https://github.com/ansible-collections/community.docker/pull/1152)." + - "docker_container_exec - fix bug that could lead to loss of stdout/stderr data (https://github.com/ansible-collections/community.docker/pull/1152)." diff --git a/plugins/module_utils/socket_handler.py b/plugins/module_utils/socket_handler.py index 878dc7c5..ced94fef 100644 --- a/plugins/module_utils/socket_handler.py +++ b/plugins/module_utils/socket_handler.py @@ -61,7 +61,7 @@ class DockerSocketHandlerBase(object): self._block_done_callback = block_done_callback if self._block_done_callback is not None: while self._block_buffer: - elt = self._block_buffer.remove(0) + elt = self._block_buffer.pop(0) self._block_done_callback(*elt) def _add_block(self, stream_id, data):