Close response instead of derived socket. (#1260)

changelogs/fragments/1260-close.yml

@@ -0,0 +1,4 @@
+bugfixes:
+  - "docker_container_exec module, docker_api connection plugin - ensure that when a command is run in a container with stdin provided, that the actual response is closed and not a socket derived from it.
+     The old behavior causes warnings to be shown on Python 3.13+ under certain conditions
+     (https://github.com/ansible-collections/community.docker/issues/1247, https://github.com/ansible-collections/community.docker/pull/1260)."

plugins/connection/docker_api.py

@@ -303,7 +303,7 @@ class Connection(ConnectionBase):
 
         data = {"Tty": False, "Detach": False}
         if need_stdin:
-            exec_socket = self._call_client(
+            exec_socket, response = self._call_client(
                 lambda client: client.post_json_to_stream_socket(
                     "/exec/{0}/start", exec_id, data=data
                 )
@@ -356,7 +356,7 @@ class Connection(ConnectionBase):
 
                     stdout, stderr = exec_socket_handler.consume()
             finally:
-                exec_socket.close()
+                response.close()
         else:
             stdout, stderr = self._call_client(
                 lambda client: client.post_json_to_stream(

plugins/module_utils/_api/api/client.py

@@ -795,7 +795,7 @@ class APIClient(_Session):
         data: t.Any = None,
         headers: dict[str, str] | None = None,
         **kwargs: t.Any,
-    ) -> SocketLike:
+    ) -> tuple[SocketLike, Response]:
         headers = headers.copy() if headers else {}
         headers.update(
             {
@@ -803,15 +803,14 @@ class APIClient(_Session):
                 "Upgrade": "tcp",
             }
         )
-        return self._get_raw_response_socket(
+        response = self._post_json(
-            self._post_json(
+            self._url(pathfmt, *args, versioned_api=True),
-                self._url(pathfmt, *args, versioned_api=True),
+            data,
-                data,
+            headers=headers,
-                headers=headers,
+            stream=True,
-                stream=True,
+            **kwargs,
-                **kwargs,
-            )
         )
+        return self._get_raw_response_socket(response), response
 
     @t.overload
     def post_json_to_stream(

plugins/modules/docker_container_exec.py

@@ -274,7 +274,7 @@ def main() -> None:
             stdout: bytes | None
             stderr: bytes | None
             if stdin and not detach:
-                exec_socket = client.post_json_to_stream_socket(
+                exec_socket, response = client.post_json_to_stream_socket(
                     "/exec/{0}/start", exec_id, data=data
                 )
                 try:
@@ -286,7 +286,7 @@ def main() -> None:
 
                         stdout, stderr = exec_socket_handler.consume()
                 finally:
-                    exec_socket.close()
+                    response.close()
             elif tty:
                 stdout, stderr = client.post_json_to_stream(
                     "/exec/{0}/start",