From 5184d6544f3d1eeeb629c84eb5b82bd73d0978cd Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Sun, 12 Oct 2025 10:26:14 +0200 Subject: [PATCH] Address unused-variable. --- .pylintrc | 1 - plugins/connection/docker.py | 2 +- plugins/connection/nsenter.py | 6 ++++-- plugins/module_utils/_api/transport/npipesocket.py | 4 ++-- plugins/module_utils/_common_api.py | 2 +- plugins/module_utils/_compose_v2.py | 2 +- plugins/module_utils/_copy.py | 2 +- plugins/module_utils/_logfmt.py | 2 +- plugins/modules/docker_plugin.py | 2 +- plugins/modules/docker_stack.py | 6 +++--- tests/unit/plugins/module_utils/_api/api/test_client.py | 2 +- 11 files changed, 16 insertions(+), 15 deletions(-) diff --git a/.pylintrc b/.pylintrc index aceb0e13..d5d69f01 100644 --- a/.pylintrc +++ b/.pylintrc @@ -393,7 +393,6 @@ disable=raw-checker-failed, unexpected-keyword-arg, unsupported-assignment-operation, # TODO: needs better typing info unused-argument, - unused-variable, use-dict-literal, # Cannot remove yet due to inadequacy of rules inconsistent-return-statements, # doesn't notice that fail_json() does not return diff --git a/plugins/connection/docker.py b/plugins/connection/docker.py index a8e53044..1f264e6c 100644 --- a/plugins/connection/docker.py +++ b/plugins/connection/docker.py @@ -426,7 +426,7 @@ class Connection(ConnectionBase): ) chunks = b"" - for key, event in events: + for key, dummy_event in events: if key.fileobj == p.stdout: chunk = p.stdout.read() if chunk: diff --git a/plugins/connection/nsenter.py b/plugins/connection/nsenter.py index 07a995b1..695ccdc9 100644 --- a/plugins/connection/nsenter.py +++ b/plugins/connection/nsenter.py @@ -178,7 +178,7 @@ class Connection(ConnectionBase): ) chunks = b"" - for key, event in events: + for key, dummy_event in events: if key.fileobj == p.stdout: chunk = p.stdout.read() if chunk: @@ -244,7 +244,9 @@ class Connection(ConnectionBase): try: with open(to_bytes(in_path, errors="surrogate_or_strict"), "rb") as in_file: in_data = in_file.read() - rc, out, err = self.exec_command(cmd=["tee", out_path], in_data=in_data) + rc, dummy_out, err = self.exec_command( + cmd=["tee", out_path], in_data=in_data + ) if rc != 0: raise AnsibleError(f"failed to transfer file to {out_path}: {err}") except IOError as e: diff --git a/plugins/module_utils/_api/transport/npipesocket.py b/plugins/module_utils/_api/transport/npipesocket.py index f178c8fd..a6c649bc 100644 --- a/plugins/module_utils/_api/transport/npipesocket.py +++ b/plugins/module_utils/_api/transport/npipesocket.py @@ -141,7 +141,7 @@ class NpipeSocket: @check_closed def recv(self, bufsize, flags=0): - err, data = win32file.ReadFile(self._handle, bufsize) + dummy_err, data = win32file.ReadFile(self._handle, bufsize) return data @check_closed @@ -163,7 +163,7 @@ class NpipeSocket: try: overlapped = pywintypes.OVERLAPPED() overlapped.hEvent = event - err, data = win32file.ReadFile( + dummy_err, dummy_data = win32file.ReadFile( self._handle, readbuf[:nbytes] if nbytes else readbuf, overlapped ) wait_result = win32event.WaitForSingleObject(event, self._timeout) diff --git a/plugins/module_utils/_common_api.py b/plugins/module_utils/_common_api.py index 6e390e69..a18739f5 100644 --- a/plugins/module_utils/_common_api.py +++ b/plugins/module_utils/_common_api.py @@ -504,7 +504,7 @@ class AnsibleDockerClientBase(Client): old_tag = self.find_image(name, tag) try: repository, image_tag = parse_repository_tag(name) - registry, repo_name = auth.resolve_repository_name(repository) + registry, dummy_repo_name = auth.resolve_repository_name(repository) params = { "tag": tag or image_tag or "latest", "fromImage": repository, diff --git a/plugins/module_utils/_compose_v2.py b/plugins/module_utils/_compose_v2.py index 3631a5c4..7328da2b 100644 --- a/plugins/module_utils/_compose_v2.py +++ b/plugins/module_utils/_compose_v2.py @@ -794,7 +794,7 @@ class BaseComposeManager(DockerBaseClass): ) def get_compose_version_from_cli(self): - rc, version_info, stderr = self.client.call_cli( + rc, version_info, dummy_stderr = self.client.call_cli( "compose", "version", "--format", "json" ) if rc: diff --git a/plugins/module_utils/_copy.py b/plugins/module_utils/_copy.py index 62c8d50f..6ee8479a 100644 --- a/plugins/module_utils/_copy.py +++ b/plugins/module_utils/_copy.py @@ -500,7 +500,7 @@ def _execute_command(client, container, command, log=None, check_rc=False): def determine_user_group(client, container, log=None): - dummy, stdout, stderr = _execute_command( + dummy_rc, stdout, dummy_stderr = _execute_command( client, container, ["/bin/sh", "-c", "id -u && id -g"], check_rc=True, log=log ) diff --git a/plugins/module_utils/_logfmt.py b/plugins/module_utils/_logfmt.py index 159281ac..c048966b 100644 --- a/plugins/module_utils/_logfmt.py +++ b/plugins/module_utils/_logfmt.py @@ -96,7 +96,7 @@ class _Parser: if self.line[self.index : self.index + 2] != "\\u": raise InvalidLogFmt("Invalid unicode escape start") v = 0 - for i in range(self.index + 2, self.index + 6): + for dummy_index in range(self.index + 2, self.index + 6): v <<= 4 try: v += _HEX_DICT[self.line[self.index]] diff --git a/plugins/modules/docker_plugin.py b/plugins/modules/docker_plugin.py index b7bcea0c..b2c19053 100644 --- a/plugins/modules/docker_plugin.py +++ b/plugins/modules/docker_plugin.py @@ -255,7 +255,7 @@ class DockerPluginManager: try: # Get privileges headers = {} - registry, repo_name = auth.resolve_repository_name( + registry, dummy_repo_name = auth.resolve_repository_name( self.parameters.plugin_name ) header = auth.get_config_header(self.client, registry) diff --git a/plugins/modules/docker_stack.py b/plugins/modules/docker_stack.py index 06fdef48..0f6fb726 100644 --- a/plugins/modules/docker_stack.py +++ b/plugins/modules/docker_stack.py @@ -184,7 +184,7 @@ except ImportError: def docker_stack_services(client, stack_name): - rc, out, err = client.call_cli( + dummy_rc, out, err = client.call_cli( "stack", "services", stack_name, "--format", "{{.Name}}" ) if to_native(err) == f"Nothing found in stack: {stack_name}\n": @@ -193,7 +193,7 @@ def docker_stack_services(client, stack_name): def docker_service_inspect(client, service_name): - rc, out, err = client.call_cli("service", "inspect", service_name) + rc, out, dummy_err = client.call_cli("service", "inspect", service_name) if rc != 0: return None ret = json.loads(out)[0]["Spec"] @@ -273,7 +273,7 @@ def main(): ) compose_files = [] - for i, compose_def in enumerate(compose): + for compose_def in compose: if isinstance(compose_def, dict): compose_file_fd, compose_file = tempfile.mkstemp() client.module.add_cleanup_file(compose_file) diff --git a/tests/unit/plugins/module_utils/_api/api/test_client.py b/tests/unit/plugins/module_utils/_api/api/test_client.py index 918d4686..e5ee57df 100644 --- a/tests/unit/plugins/module_utils/_api/api/test_client.py +++ b/tests/unit/plugins/module_utils/_api/api/test_client.py @@ -364,7 +364,7 @@ class UnixSocketStreamTest(unittest.TestCase): try: while not self.stop_server: try: - connection, client_address = self.server_socket.accept() + connection, dummy_client_address = self.server_socket.accept() except socket.error: # Probably no connection to accept yet time.sleep(0.01)