Add typing information, 1/2 (#1176)

* Re-enable typing and improve config.

* Make mypy pass.

* Improve settings.

* First batch of types.

* Add more type hints.

* Fixes.

* Format.

* Fix split_port() without returning to previous type chaos.

* Continue with type hints (and ignores).

tests/sanity/ignore-2.17.txt

@@ -1 +1,22 @@
+plugins/connection/docker.py no-assert
+plugins/connection/docker_api.py no-assert
+plugins/connection/nsenter.py no-assert
+plugins/module_utils/_api/api/client.py pep8:E704
+plugins/module_utils/_api/transport/sshconn.py no-assert
+plugins/module_utils/_api/utils/build.py no-assert
+plugins/module_utils/_api/utils/ports.py pep8:E704
+plugins/module_utils/_api/utils/socket.py pep8:E704
+plugins/module_utils/_common_cli.py pep8:E704
+plugins/module_utils/_module_container/module.py no-assert
+plugins/module_utils/_platform.py no-assert
+plugins/module_utils/_socket_handler.py no-assert
+plugins/module_utils/_swarm.py pep8:E704
+plugins/module_utils/_util.py pep8:E704
 plugins/modules/docker_container_copy_into.py validate-modules:undocumented-parameter # _max_file_size_for_diff is used by the action plugin
+plugins/modules/docker_container_exec.py no-assert
+plugins/modules/docker_container_exec.py pylint:unpacking-non-sequence
+plugins/modules/docker_image.py no-assert
+plugins/modules/docker_image_tag.py no-assert
+plugins/modules/docker_login.py no-assert
+plugins/modules/docker_plugin.py no-assert
+plugins/modules/docker_volume.py no-assert

tests/sanity/ignore-2.18.txt

@@ -1 +1,21 @@
+plugins/connection/docker.py no-assert
+plugins/connection/docker_api.py no-assert
+plugins/connection/nsenter.py no-assert
+plugins/module_utils/_api/api/client.py pep8:E704
+plugins/module_utils/_api/transport/sshconn.py no-assert
+plugins/module_utils/_api/utils/build.py no-assert
+plugins/module_utils/_api/utils/ports.py pep8:E704
+plugins/module_utils/_api/utils/socket.py pep8:E704
+plugins/module_utils/_common_cli.py pep8:E704
+plugins/module_utils/_module_container/module.py no-assert
+plugins/module_utils/_platform.py no-assert
+plugins/module_utils/_socket_handler.py no-assert
+plugins/module_utils/_swarm.py pep8:E704
+plugins/module_utils/_util.py pep8:E704
 plugins/modules/docker_container_copy_into.py validate-modules:undocumented-parameter # _max_file_size_for_diff is used by the action plugin
+plugins/modules/docker_container_exec.py no-assert
+plugins/modules/docker_image.py no-assert
+plugins/modules/docker_image_tag.py no-assert
+plugins/modules/docker_login.py no-assert
+plugins/modules/docker_plugin.py no-assert
+plugins/modules/docker_volume.py no-assert

tests/sanity/ignore-2.19.txt

@@ -1 +1,15 @@
+plugins/connection/docker.py no-assert
+plugins/connection/docker_api.py no-assert
+plugins/connection/nsenter.py no-assert
+plugins/module_utils/_api/transport/sshconn.py no-assert
+plugins/module_utils/_api/utils/build.py no-assert
+plugins/module_utils/_module_container/module.py no-assert
+plugins/module_utils/_platform.py no-assert
+plugins/module_utils/_socket_handler.py no-assert
 plugins/modules/docker_container_copy_into.py validate-modules:undocumented-parameter # _max_file_size_for_diff is used by the action plugin
+plugins/modules/docker_container_exec.py no-assert
+plugins/modules/docker_image.py no-assert
+plugins/modules/docker_image_tag.py no-assert
+plugins/modules/docker_login.py no-assert
+plugins/modules/docker_plugin.py no-assert
+plugins/modules/docker_volume.py no-assert

tests/sanity/ignore-2.20.txt

@@ -1 +1,15 @@
+plugins/connection/docker.py no-assert
+plugins/connection/docker_api.py no-assert
+plugins/connection/nsenter.py no-assert
+plugins/module_utils/_api/transport/sshconn.py no-assert
+plugins/module_utils/_api/utils/build.py no-assert
+plugins/module_utils/_module_container/module.py no-assert
+plugins/module_utils/_platform.py no-assert
+plugins/module_utils/_socket_handler.py no-assert
 plugins/modules/docker_container_copy_into.py validate-modules:undocumented-parameter # _max_file_size_for_diff is used by the action plugin
+plugins/modules/docker_container_exec.py no-assert
+plugins/modules/docker_image.py no-assert
+plugins/modules/docker_image_tag.py no-assert
+plugins/modules/docker_login.py no-assert
+plugins/modules/docker_plugin.py no-assert
+plugins/modules/docker_volume.py no-assert

tests/sanity/ignore-2.21.txt

@@ -1 +1,15 @@
+plugins/connection/docker.py no-assert
+plugins/connection/docker_api.py no-assert
+plugins/connection/nsenter.py no-assert
+plugins/module_utils/_api/transport/sshconn.py no-assert
+plugins/module_utils/_api/utils/build.py no-assert
+plugins/module_utils/_module_container/module.py no-assert
+plugins/module_utils/_platform.py no-assert
+plugins/module_utils/_socket_handler.py no-assert
 plugins/modules/docker_container_copy_into.py validate-modules:undocumented-parameter # _max_file_size_for_diff is used by the action plugin
+plugins/modules/docker_container_exec.py no-assert
+plugins/modules/docker_image.py no-assert
+plugins/modules/docker_image_tag.py no-assert
+plugins/modules/docker_login.py no-assert
+plugins/modules/docker_plugin.py no-assert
+plugins/modules/docker_volume.py no-assert

tests/unit/plugins/module_utils/_api/transport/test_ssladapter.py

@@ -19,7 +19,7 @@ from ansible_collections.community.docker.plugins.module_utils._api.transport im
 
 
 try:
-    from ssl import CertificateError, match_hostname
+    from ssl import CertificateError, match_hostname  # type: ignore
 except ImportError:
     HAS_MATCH_HOSTNAME = False  # pylint: disable=invalid-name
 else:

tests/unit/plugins/module_utils/_api/utils/test_config.py

@@ -12,8 +12,8 @@ import json
 import os
 import shutil
 import tempfile
-import typing as t
 import unittest
+from collections.abc import Callable
 from unittest import mock
 
 from pytest import fixture, mark
@@ -22,7 +22,7 @@ from ansible_collections.community.docker.plugins.module_utils._api.utils import
 
 
 class FindConfigFileTest(unittest.TestCase):
-    mkdir: t.Callable[[str], os.PathLike[str]]
+    mkdir: Callable[[str], os.PathLike[str]]
 
     @fixture(autouse=True)
     def tmpdir(self, tmpdir):

tests/unit/plugins/module_utils/compose_v2_test_cases.py

@@ -11,7 +11,7 @@ from ansible_collections.community.docker.plugins.module_utils._compose_v2 impor
 )
 
 
-EVENT_TEST_CASES = [
+EVENT_TEST_CASES: list[tuple[str, str, bool, bool, str, list[Event], list[Event]]] = [
     # #######################################################################################################################
     # ## Docker Compose 2.18.1 ##############################################################################################
     # #######################################################################################################################