ansible-collections/community.docker
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.docker.git synced 2025-12-17 12:28:55 +00:00
Code Packages Projects Releases Wiki Activity

removes advertise_addr from required parameters when state is "join" (#646)

Browse Source 
* removes advertise_addr from required parameters when state is "join"

addressing this issue: https://github.com/ansible-collections/community.general/issues/439

* adjusts test

* adds changelog
This commit is contained in:
Minh Ha 2020-07-20 12:14:16 -04:00 committed by Felix Fontein
parent 7d44ce9635
commit 19f35bae91
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/modules/docker_swarm.py
View File

@ -627,7 +627,7 @@ def main():
) )
required_if = [ required_if = [
('state', 'join', ['advertise_addr', 'remote_addrs', 'join_token']), ('state', 'join', ['remote_addrs', 'join_token']),
('state', 'remove', ['node_id']) ('state', 'remove', ['node_id'])
] ]

4
tests/integration/targets/docker_swarm/tasks/tests/basic.yml
View File

@ -10,11 +10,11 @@
ignore_errors: yes ignore_errors: yes
register: output register: output
- name: assert failure when called with state=join and no advertise_addr,remote_addrs,join_token - name: assert failure when called with state=join and no remote_addrs,join_token
assert: assert:
that: that:
- 'output.failed' - 'output.failed'
- 'output.msg == "state is join but all of the following are missing: advertise_addr, remote_addrs, join_token"' - 'output.msg == "state is join but all of the following are missing: remote_addrs, join_token"'
- name: Test parameters with state=remove - name: Test parameters with state=remove
docker_swarm: docker_swarm: